Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

After thinking about this for a while, I came to think, that we also need a jslinter job for murano-dashboard. Horizon is currently adopting eslint as a one tool for the job (meant to replace jscs and jshint afaiu), so we could adopt this as part of the blueprint, I filed. --  Kirill Zaitsev Mu

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

Since there were no objections, and as a follow-up I’ve created a BP for that in murano: https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs --  Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 10 Jun 2015 at 18:07:19, Filip Blaha (filip.bl...@hp.com) wrote: Thanks fo

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

Thanks for comment and suggestion! there is also shutil2 framework for unit testing over shell scripts. We shall consider it whether it could bring us value for the effort. I personally have no strong opinion about that. Little contradiction to my previous mail:-) Regards Filip On 06/10/2

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote: > +1, nice idea. Shell script are not easy to review - large files, not > covered by unit tests. Any automatic tool could be beneficial. It's worth noting that just because your shell scripts don't have their own validation tests doesn't mea

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

+1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial. Regards Filip On 06/09/2015 09:58 PM, Kirill Zaitsev wrote: Folks, I’ve got another proposal, mainly to the guys, who deal with CI and test jobs daily. What wo

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

Hi Kirill, +1 from my side, shellcheck + bashate can help to increase quality of CI scripts. On Wed, Jun 10, 2015 at 2:19 PM, Igor Yozhikov wrote: > Hi, I'm using shellcheck during automation scripts writing as linter and I > believe that incorporation of this tool for additional verification i

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

Hi, I'm using shellcheck during automation scripts writing as linter and I believe that incorporation of this tool for additional verification in CI is good idea. Thanks, Igor Yozhikov Senior Deployment Engineer at Mirantis skype: igor.yozhikov cellular: +7 901 5331200 s

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

On Tue, Jun 9, 2015 at 2:58 PM, Kirill Zaitsev wrote: > What would you say about adding a job to murano-deployment, that would > launch shellcheck http://www.shellcheck.net/about.html against all .sh > files? > We looked at shellcheck when the idea for bashate was brewing, frankly the Haskell ru

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

On 2015-06-09 20:40:48 + (+), Jeremy Stanley wrote: > On 2015-06-09 22:58:15 +0300 (+0300), Kirill Zaitsev wrote: > [...] > > What would you say about adding a job to murano-deployment, that > > would launch > > shellcheck http://www.shellcheck.net/about.html against all .sh > > files?  > [

Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

On 2015-06-09 22:58:15 +0300 (+0300), Kirill Zaitsev wrote: [...] > What would you say about adding a job to murano-deployment, that > would launch > shellcheck http://www.shellcheck.net/about.html against all .sh > files?  [...] Ooh, that looks neat. Note we also already use http://git.openstack.

[openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

Folks, I’ve got another proposal, mainly to the guys, who deal with CI and test jobs daily. What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files?  I use it, when reviewing .sh scripts (well, actually