Re: [openstack-dev] [neutron][vpnaas] Working on unit tests...

2014-12-14 Thread Paul Michali (pcm)
Thanks for checking the changes and confirming! BTW, my change set had a fix from Ihar (141405). Rather than approve this as-is, which would void Ihar's, I approved Ihar’s change, and then will rebase mine on his, once it is upstream (wanted to give him credit for his changes). Regards, PCM

[openstack-dev] [neutron][vpnaas] Working on unit tests...

2014-12-13 Thread Paul Michali (pcm)
For the new VPNaaS repo, I have created https://review.openstack.org/#/c/141532/ to move the tests from tests.skip and modify the imports. This has Brandon’s change to setup policy.json, and Ihar’s one-liner for moving get_admin_context() in one test (should we upstream his, and I rebase

Re: [openstack-dev] [neutron][vpnaas] Working on unit tests...

2014-12-13 Thread Brandon Logan
Paul, It looks like you put that method call in all the right places. You would know if you didn't, because the unit tests would fail bc of the policy.json. Not sure on the tempests tests. I'm sure Doug and Kyle know more about that, so hopefully they can chime in. Thanks, Brandon On Sat,