Re: [openstack-dev] [neutron][vpnaas] Working on unit tests...
Thanks for checking the changes and confirming! BTW, my change set had a fix from Ihar (141405). Rather than approve this as-is, which would void Ihar's, I approved Ihar’s change, and then will rebase mine on his, once it is upstream (wanted to give him credit for his changes). Regards, PCM (Paul Michali) MAIL …..…. p...@cisco.com IRC ……..… pc_m (irc.freenode.com) TW ………... @pmichali GPG Key … 4525ECC253E31A83 Fingerprint .. 307A 96BB 1A4C D2C7 931D 8D2D 4525 ECC2 53E3 1A83 On Dec 14, 2014, at 12:31 AM, Brandon Logan brandon.lo...@rackspace.com wrote: Paul, It looks like you put that method call in all the right places. You would know if you didn't, because the unit tests would fail bc of the policy.json. Not sure on the tempests tests. I'm sure Doug and Kyle know more about that, so hopefully they can chime in. Thanks, Brandon On Sat, 2014-12-13 at 19:06 +, Paul Michali (pcm) wrote: For the new VPNaaS repo, I have created https://review.openstack.org/#/c/141532/ to move the tests from tests.skip and modify the imports. This has Brandon’s change to setup policy.json, and Ihar’s one-liner for moving get_admin_context() in one test (should we upstream his, and I rebase mine?). Please look it over, as I’m not sure if I put the override_nvalues() calls in the right places or not. It passes unit tests in Jenkins. The Tempest tests all fail. Is that expected? What’s the plan for functional and tempest tests with these other repos? Thanks! PCM (Paul Michali) MAIL …..…. p...@cisco.com IRC ……..… pc_m (irc.freenode.com) TW ………... @pmichali GPG Key … 4525ECC253E31A83 Fingerprint .. 307A 96BB 1A4C D2C7 931D 8D2D 4525 ECC2 53E3 1A83 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [neutron][vpnaas] Working on unit tests...
For the new VPNaaS repo, I have created https://review.openstack.org/#/c/141532/ to move the tests from tests.skip and modify the imports. This has Brandon’s change to setup policy.json, and Ihar’s one-liner for moving get_admin_context() in one test (should we upstream his, and I rebase mine?). Please look it over, as I’m not sure if I put the override_nvalues() calls in the right places or not. It passes unit tests in Jenkins. The Tempest tests all fail. Is that expected? What’s the plan for functional and tempest tests with these other repos? Thanks! PCM (Paul Michali) MAIL …..…. p...@cisco.com IRC ……..… pc_m (irc.freenode.com) TW ………... @pmichali GPG Key … 4525ECC253E31A83 Fingerprint .. 307A 96BB 1A4C D2C7 931D 8D2D 4525 ECC2 53E3 1A83 signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][vpnaas] Working on unit tests...
Paul, It looks like you put that method call in all the right places. You would know if you didn't, because the unit tests would fail bc of the policy.json. Not sure on the tempests tests. I'm sure Doug and Kyle know more about that, so hopefully they can chime in. Thanks, Brandon On Sat, 2014-12-13 at 19:06 +, Paul Michali (pcm) wrote: For the new VPNaaS repo, I have created https://review.openstack.org/#/c/141532/ to move the tests from tests.skip and modify the imports. This has Brandon’s change to setup policy.json, and Ihar’s one-liner for moving get_admin_context() in one test (should we upstream his, and I rebase mine?). Please look it over, as I’m not sure if I put the override_nvalues() calls in the right places or not. It passes unit tests in Jenkins. The Tempest tests all fail. Is that expected? What’s the plan for functional and tempest tests with these other repos? Thanks! PCM (Paul Michali) MAIL …..…. p...@cisco.com IRC ……..… pc_m (irc.freenode.com) TW ………... @pmichali GPG Key … 4525ECC253E31A83 Fingerprint .. 307A 96BB 1A4C D2C7 931D 8D2D 4525 ECC2 53E3 1A83 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
