Re: [openstack-dev] [oslo] oslo.versionedobjects repository is ready for pre-import review

2015-02-06 Thread Ben Nemec
Overall looks good to me and the unit tests are passing locally. I'm wondering about some of the stuff that was left commented out without a FIXME and left a couple of comments about them, but I'm mostly assuming they were just things commented for testing that weren't removed later. -Ben On 02/

Re: [openstack-dev] [oslo] oslo.versionedobjects repository is ready for pre-import review

2015-02-02 Thread Doug Hellmann
On Mon, Feb 2, 2015, at 04:33 PM, Doug Hellmann wrote: > I’ve prepared a copy of nova.objects as oslo_versionedobjects in > https://github.com/dhellmann/oslo.versionedobjects-import. The script to > create the repository is part of the update to the spec in > https://review.openstack.org/15.

[openstack-dev] [oslo] oslo.versionedobjects repository is ready for pre-import review

2015-02-02 Thread Doug Hellmann
I’ve prepared a copy of nova.objects as oslo_versionedobjects in https://github.com/dhellmann/oslo.versionedobjects-import. The script to create the repository is part of the update to the spec in https://review.openstack.org/15. Please look over the code so you are familiar with it. Dan an