Re: [openstack-dev] [puppet][puppet-ceph] missing dependencies for openstacklib::openstackclient in metadata.json

[Alex Schultz]

On Mon, Sep 25, 2017 at 5:42 AM, Emil Enemærke  wrote:
> There is also missing dependency for openstack/keystone, which is also used
> in ceph::rgw::keystone::auth line 63, 68, 75, 85
>
> On Mon, Sep 25, 2017 at 1:00 PM, Emil Enemærke  wrote:
>>
>> Hi
>>
>> In class ceph::rgw::keystone::auth there is an include for
>> ::openstacklib::openstackclient (line 61), but there is no dependency for it
>> in the metadata.json file.
>>

https://review.openstack.org/507141

Thanks,
-Alex

>> Cheers
>> Emil
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet][puppet-ceph] missing dependencies for openstacklib::openstackclient in metadata.json

[Emil Enemærke]

There is also missing dependency for openstack/keystone, which is also used
in ceph::rgw::keystone::auth line 63, 68, 75, 85

On Mon, Sep 25, 2017 at 1:00 PM, Emil Enemærke  wrote:

> Hi
>
> In class ceph::rgw::keystone::auth there is an include for 
> ::openstacklib::openstackclient
> (line 61), but there is no dependency for it in the metadata.json file.
>
> Cheers
> Emil
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [puppet][puppet-ceph] missing dependencies for openstacklib::openstackclient in metadata.json

[Emil Enemærke]

Hi

In class ceph::rgw::keystone::auth there is an include for
::openstacklib::openstackclient (line 61), but there is no dependency for
it in the metadata.json file.

Cheers
Emil
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet][puppet-ceph]

[Andrew Woodward]

On Tue, Sep 5, 2017 at 6:47 AM Mohammed Naser  wrote:

> On Tue, Sep 5, 2017 at 4:15 AM, Emil Enemærke  wrote:
> > Hi,
> >
> > I have stated using the puppet-ceph module for deploying ceph, and have
> > noticed a heavy use of exec in fx define 'ceph::osd'
> > (https://github.com/openstack/puppet-ceph/blob/master/manifests/osd.pp).
> Is
> > there a reason for not writing this define as an ensurable type/provider?
> > Otherwise I will fork the module an start on rewriting it for a
> > type/provider.
> >
>
> Thanks for helping out.  I'm happy to see folks using the puppet-ceph
> modules!  I think the reason why we've relied of the Exec's is purely
> historic.  If you have a patch that would convert it to an ensurable
> type and provider, we'd be more than happy to merge it!
>

As manser pointed out, the reason for the exec's is purely historic, in
that the initial implementation team  wasn't comfortable with developing
ruby providers given our familiarity at the time. It was easier for us to
develop and troubleshoot the execs directly.

We'd be more than happy to have reviews to migrate to a ruby implementation

If you have any questions, feel free to pop by on #puppet-openstack on
freenode


> >
> > Cheers
> > Emil
> >
> >
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-- 
Andrew Woodward
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet][puppet-ceph]

[Mohammed Naser]

On Tue, Sep 5, 2017 at 4:15 AM, Emil Enemærke  wrote:
> Hi,
>
> I have stated using the puppet-ceph module for deploying ceph, and have
> noticed a heavy use of exec in fx define 'ceph::osd'
> (https://github.com/openstack/puppet-ceph/blob/master/manifests/osd.pp). Is
> there a reason for not writing this define as an ensurable type/provider?
> Otherwise I will fork the module an start on rewriting it for a
> type/provider.
>

Thanks for helping out.  I'm happy to see folks using the puppet-ceph
modules!  I think the reason why we've relied of the Exec's is purely
historic.  If you have a patch that would convert it to an ensurable
type and provider, we'd be more than happy to merge it!

>
> Cheers
> Emil
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [puppet][puppet-ceph]

[Emil Enemærke]

Hi,

I have stated using the puppet-ceph module for deploying ceph, and have
noticed a heavy use of exec in fx define 'ceph::osd' (
https://github.com/openstack/puppet-ceph/blob/master/manifests/osd.pp). Is
there a reason for not writing this define as an ensurable type/provider?
Otherwise I will fork the module an start on rewriting it for a
type/provider.

Cheers
Emil
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev