On 2013-10-23 04:29, Rosa, Andrea (HP Cloud Services) wrote:
Hi
2. Before submitting the new patch for review it's better to run unit
tests (tox -epy27) and pep8 check (tox -epep8)
Instead of pep8 I think you should run flake8 we moved to that some
months ago[1].
Usually I find always useful
Hi
>On 23.10.2013 11:29, Rosa, Andrea (HP Cloud Services) wrote:
>> Usually I find always useful to test my changes in devstack.
>
>How do you do that? I think the devstack does not always contain up to date
>codebase does it, so what would be the point in testing changes on the old
>code?
With de
Hey,
On 23.10.2013 11:29, Rosa, Andrea (HP Cloud Services) wrote:
Usually I find always useful to test my changes in devstack.
How do you do that? I think the devstack does not always contain up to
date codebase does it, so what would be the point in testing changes on
the old code?
Thanks
Hi
> 2. Before submitting the new patch for review it's better to run unit tests
> (tox -epy27) and pep8 check (tox -epep8)
Instead of pep8 I think you should run flake8 we moved to that some months
ago[1].
Usually I find always useful to test my changes in devstack.
Regards
--
Andrea Rosa
[1]
uot;. If it's really not
caused by any bug, do "recheck no bug".
Thanks,
Avishay
From: Eugene Nikanorov
To: OpenStack Development Mailing List
,
Date: 10/23/2013 12:07 PM
Subject: Re: [openstack-dev] Testing before sending for review
Hi,
1. It's
Hi,
1. It's not necessary to abandon your patch if it has failed jenkins tests.
2. Before submitting the new patch for review it's better to run unit tests
(tox -epy27) and pep8 check (tox -epep8)
Integration testing is being done by check-tempest-devstack-vm-neutron*
suites and some of them fail
Hi All,
I posted a review earlier - https://review.openstack.org/#/c/53160/, which
failed Jenkins test. I realized that changes required in other files too. I
'Abandoned Changes' so that I can post review set again. I have made the
changes now, but want to test them before sending for review.
I
