Re: [openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Tom Fifield
On 01/11/13 08:35, Mark McLoughlin wrote: On Thu, 2013-10-31 at 11:49 -0700, Stefano Maffulli wrote: Another idea that Tom suggested is to use gerrit automation to send back to first time committers something in addition to the normal 'your patch is waiting for review' message. The message coul

Re: [openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Mark McLoughlin
On Thu, 2013-10-31 at 11:49 -0700, Stefano Maffulli wrote: > Another idea that Tom suggested is to use gerrit automation to send back > to first time committers something in addition to the normal 'your patch > is waiting for review' message. The message could be something like: > > > thank you f

Re: [openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Kyle Mestery (kmestery)
On Oct 31, 2013, at 3:21 PM, Monty Taylor wrote: > > > On 10/31/2013 04:15 PM, Kyle Mestery (kmestery) wrote: >> On Oct 31, 2013, at 1:49 PM, Stefano Maffulli wrote: >>> On 10/31/2013 07:05 AM, Kyle Mestery (kmestery) wrote: >>> [...] If we want to grow the committer base and help people t

Re: [openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Monty Taylor
On 10/31/2013 04:15 PM, Kyle Mestery (kmestery) wrote: > On Oct 31, 2013, at 1:49 PM, Stefano Maffulli wrote: >> On 10/31/2013 07:05 AM, Kyle Mestery (kmestery) wrote: >> [...] >>> If we want to grow the committer base and help people to become >>> better reviewers, taking the time to show them

Re: [openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Kyle Mestery (kmestery)
On Oct 31, 2013, at 1:49 PM, Stefano Maffulli wrote: > On 10/31/2013 07:05 AM, Kyle Mestery (kmestery) wrote: > [...] >> If we want to grow the committer base and help people to become >> better reviewers, taking the time to show them the ropes is part of >> the game. > > hijacking the thread usi

[openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Stefano Maffulli
On 10/31/2013 07:05 AM, Kyle Mestery (kmestery) wrote: [...] > If we want to grow the committer base and help people to become > better reviewers, taking the time to show them the ropes is part of > the game. hijacking the thread using Kyle's comment as an excuse. It's not an 'if' but a 'since':