[openstack-dev] [puppet] Move to rspec-puppet 2.2.0

2015-06-09 Thread Cody Herriges
Seemingly simple proposition of moving from rspec-puppet 2.1.0 to 2.2.0 so as to address the issue of helper library loading that is shipped as part of a few of our modules. In my specific case, puppet-vswitch's puppetx library directory and its use by puppet-neutron. This is part of the effort

[openstack-dev] [puppet] review getting long in the tooth

2015-06-15 Thread Cody Herriges
Sync up module with latest msync commit. - https://review.openstack.org/#/c/189873 Make tests pass on Puppet 4.x - https://review.openstack.org/#/c/184646/ For what ever reason these two patch sets keep getting reviewed then either rebased or I implement minor non-blocking comments and

Re: [openstack-dev] [puppet] Change abandonment policy

2015-06-02 Thread Cody Herriges
Colleen Murphy wrote: snip 3) Manually abandon after N months/weeks changes that have a -1 that was never responded to ``` If a change is submitted and given a -1, and subsequently the author becomes unresponsive for a few weeks, reviewers should leave reminder comments on the review or

Re: [openstack-dev] [puppet] about $::os_service_default

2015-11-13 Thread Cody Herriges
Yanis Guenane wrote: > > On 11/03/2015 02:57 PM, Emilien Macchi wrote: >> I'm seeing a lot of patches using the new $::os_service_default. >> >> Please stop trying to using it at this time. The feature is not stable >> yet and we're testing it only for puppet-cinder module. >> I've heard Yanis

Re: [openstack-dev] [puppet] operator_roles in puppet-swift?

2015-11-02 Thread Cody Herriges
Matt Fischer wrote: > I'd like to get some clarification and hopefully correction on the > values for the two operator_roles variables. One is > in manifests/keystone/auth.pp, and it claims "Array of strings. List of > roles Swift considers as admin.". The other is > in manifests/proxy/keystone.pp

Re: [openstack-dev] [puppet] Match type checking from oslo.config.

2015-11-02 Thread Cody Herriges
Sofer Athlan-Guyot wrote: > Hi, > > The idea would be to have some of the types defined oslo config > http://git.openstack.org/cgit/openstack/oslo.config/tree/oslo_config/types.py > ported to puppet type. Those that looks like good candidates are: > - Boolean; > - IPAddress; > and in a lesser

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Cody Herriges
Emilien Macchi wrote: > We did our meeting: > http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-11-17-15.00.html > Now that updates to the wiki doc "Coding_style" are happening, are we going to block patches that are already proposed that use the old "" pattern?

Re: [openstack-dev] [puppet] service default value functions

2015-09-16 Thread Cody Herriges
Emilien Macchi wrote: > > On 09/16/2015 12:53 PM, Alex Schultz wrote: >> Hey puppet folks, >> >> Based on the meeting yesterday[0], I had proposed creating a parser >> function called is_service_default[1] to validate if a variable matched >> our agreed upon value of ''. This got me thinking >>

Re: [openstack-dev] [puppet][keystone] Choose domain names with 'composite namevar' or 'meaningless name'?

2015-09-16 Thread Cody Herriges
I wrote my first composite namevar type a few years and ago and all the magic is basically a single block of code inside the type... https://github.com/puppetlabs/puppetlabs-java_ks/blob/master/lib/puppet/type/java_ks.rb#L145-L169 It basically boils down to these three things: * Pick your

Re: [openstack-dev] [puppet] service default value functions

2015-09-23 Thread Cody Herriges
Alex Schultz wrote: >> I've been mulling this over the last several days and I just can't >> accept an entire ruby function which would be ran for every parameter >> with the desired static value of "" when the class is >> declared and parsed. I am not generally against using functions as a >>

Re: [openstack-dev] [puppet] service default value functions

2015-09-22 Thread Cody Herriges
Alex Schultz wrote: > Hey puppet folks, > > Based on the meeting yesterday[0], I had proposed creating a parser > function called is_service_default[1] to validate if a variable matched > our agreed upon value of ''. This got me thinking > about how can we maybe not use the arbitrary string

Re: [openstack-dev] [puppet] including openstacklib::openstackclient

2015-12-08 Thread Cody Herriges
Matt Fischer wrote: > I found this bug in the liberty branch [1] over the weekend in the > handling of openstack client between glance & keystone. As a part of > fixing that I've discussed with Clayton and Michael Chapman just what > the right way is to include the openstackclient. > > Keystone

Re: [openstack-dev] [puppet] Config support for oslo.config.cfg.MultiStrOpt

2015-12-02 Thread Cody Herriges
Martin, I see no reason this shouldn't just be pushed into puppetlabs-inifile. I can't actually find a real "spec" for INI file and even the Wiki link[3] calls out that there is no actual spec. On Fri, Nov 27, 2015 at 5:04 AM, Martin Mágr wrote: > Greetings, > > I've

Re: [openstack-dev] [puppet] proposing Cody Herriges part of Puppet OpenStack core

2015-12-09 Thread Cody Herriges
Thank you everyone for the support! I am quite excited to be working in this community again. Is has been a long road for me to get back here from the day Dan Bode passed things on to me and I did the 2.0.0 release to the Forge and then a quick hand off again to Chris. In retrospect I regret

Re: [openstack-dev] [puppet] Puppet 4 and Beaker testing

2015-12-03 Thread Cody Herriges
Cody Herriges wrote: > Today we do unit testing against all kinds of puppet versions but > beaker's acceptance testing is currently limited to the 3.8.x series. > The is because we install "latest" Puppet from Puppet Labs repositories > but do so using the old packag

Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack

2015-12-16 Thread Cody Herriges
Emilien Macchi wrote: > I just noticed we have a second module written by Cody: > https://github.com/ody/puppet-rally > > We might want to collaborate on that. > Yeah...I'd actually completely forgotten that existed until Emilien mentioned it to me in IRC. It was my responsibility to deploy

Re: [openstack-dev] [puppet] proposing Alex Schultz part of core team

2016-01-06 Thread Cody Herriges
Emilien Macchi wrote: > Hi, > > Alex Schultz (mwhahaha on IRC) has been a very active contributor over > the last months in the Puppet OpenStack group: > * He's doing a lot of reviews and they are very valuable. He's in my > opinion fully aware of our conventions and has nice insights to improve

Re: [openstack-dev] [puppet] Adding "IPv6" bracket handling utilities in openstacklib.

2016-01-08 Thread Cody Herriges
Sofer Athlan-Guyot wrote: > Hi all, > > I've got an input from a fellow worker[1]. Basically, transparently > transforming user data in puppet is opening a big can of worms. > > He came up with a rather contrived example, but it's definitively worth > discussing it. > > So in the vncproxy

Re: [openstack-dev] [puppet] Adding "IPv6" bracket handling utilities in openstacklib.

2016-01-07 Thread Cody Herriges
Sofer Athlan-Guyot wrote: > Hi, > > There are a few places where I would like to be able to check for IPv6 > address and add bracket to the parameters. I think that would be a nice > addition to the puppet-openstacklib/lib/puppet/parser. > > Here the interface I have in mind with the

[openstack-dev] [puppet] Puppet 4 and Beaker testing

2015-11-24 Thread Cody Herriges
Today we do unit testing against all kinds of puppet versions but beaker's acceptance testing is currently limited to the 3.8.x series. The is because we install "latest" Puppet from Puppet Labs repositories but do so using the old packaging style which relied on dependency packages being

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-17 Thread Cody Herriges
Iury Gregory wrote: > Hi Cody, > If there is patches using $::os_service_default and they are blocked, I > think the owner just need to request removal and continue the work.( I > think ) > Iury, Now that the standard is $::os_service_default does it mean that current changes up for review

Re: [openstack-dev] [puppet] weekly meeting #59

2015-11-19 Thread Cody Herriges
Clayton O'Neill wrote: > On Tue, Nov 17, 2015 at 4:38 PM, Cody Herriges <c...@puppetlabs.com > <mailto:c...@puppetlabs.com>> wrote: > > Now that the standard is $::os_service_default does it mean that current > changes up for review with parameters set to the st

Re: [openstack-dev] [puppet] mime-types-data requires Ruby version >= 2.0

2015-11-23 Thread Cody Herriges
Cody Herriges wrote: > Emilien Macchi wrote: >> Because of [1], [2] and [3]: all beaker-rspec-dsvm-trusty jobs are broken. >> >> The only one option I see is to pin mime-types in beaker dependencies, >> because beaker needs frog and frog needs mime-types. >> &

Re: [openstack-dev] [puppet] mime-types-data requires Ruby version >= 2.0

2015-11-23 Thread Cody Herriges
Emilien Macchi wrote: > Because of [1], [2] and [3]: all beaker-rspec-dsvm-trusty jobs are broken. > > The only one option I see is to pin mime-types in beaker dependencies, > because beaker needs frog and frog needs mime-types. > > Note beaker is currently broken for ubuntu trusty nodes,

Re: [openstack-dev] [puppet] Discussion of PuppetOpenstack Project abbreviation

2016-06-01 Thread Cody Herriges
> On Jun 1, 2016, at 5:56 AM, Dmitry Tantsur wrote: > > On 06/01/2016 02:20 PM, Jason Guiditta wrote: >> On 01/06/16 18:49 +0800, Xingchao Yu wrote: >>> Hi, everyone: >>> >>> Do we need to give a abbreviation for PuppetOpenstack project? B/C >>> it's really a long

Re: [openstack-dev] [puppet] sprint starts today

2016-01-25 Thread Cody Herriges
Emilien Macchi wrote: > Hello! > > Puppet OpenStack team is starting a 3-days sprint today. > > Here are the topics we're going to work on: > https://etherpad.openstack.org/p/puppet-happy-new-year-2016 > > You can join our efforts on #openstack-sprint, you'll be more than welcome! > Missing

Re: [openstack-dev] [puppet] [oslo] Proposal of adding puppet-oslo to OpenStack

2016-01-19 Thread Cody Herriges
Colleen Murphy wrote: > On Tue, Jan 19, 2016 at 9:57 AM, Xingchao Yu > wrote: > > Hi, Emilien: > > Thanks for your efforts on this topic, I didn't attend V > release summit and missed related discussion about puppet-oslo. > >

Re: [openstack-dev] [puppet] Midcycle Sprint Summary

2016-02-01 Thread Cody Herriges
Emilien Macchi wrote: > Last week, we had our midcycle sprint. > Our group did a great job and here is a summary of what we worked on: > My attention at the office was stolen quite a few times by finishing up work for our production cloud deployment but I worked on the pupept-cinder Mitaka

Re: [openstack-dev] [puppet] proposal to create puppet-neutron-core and add Sergey Kolekonov

2016-03-04 Thread Cody Herriges
Emilien Macchi wrote: > Hi, > > To scale-up our review process, we created pupept-keystone-core and it > worked pretty well until now. > > I propose that we continue this model and create puppet-neutron-core. > > I also propose to add Sergey Kolekonov in this group. > He's done a great job

Re: [openstack-dev] [puppet] Stepping down from puppet-openstack-core

2016-04-20 Thread Cody Herriges
> On Apr 18, 2016, at 8:37 AM, Sebastien Badia wrote: > > Hello here, > > I would like to ask to be removed from the core reviewers team on the > Puppet for OpenStack project. > > I lack dedicated time to contribute on my spare time to the project. And I > don't work anymore on

[openstack-dev] [puppet] Thank you.

2017-01-24 Thread Cody Herriges
reasons. I hope to get a more hobby like enjoyment out of the low level practioner bits of OpenStack from here on out. -- Cody Herriges __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev

[openstack-dev] [puppet] Puppet 4 related backports

2016-09-07 Thread Cody Herriges
For an ongoing project here at Puppet I needed to validate the stable/mitaka branches against Puppet 4.  I've done that for all three scenarios but doing so required a few backports of items currently in master. https://review.openstack.org/#/c/296557/ https://review.openstack.org/#/c/310794/

Re: [openstack-dev] [puppet] Puppet OpenStack PTL non-candidacy

2016-09-09 Thread Cody Herriges
On September 9, 2016 at 9:08:56 AM, Emilien Macchi (emil...@redhat.com) wrote: Hi, I wrote a little blog post about the last cycle in PuppetOpenStack: http://my1.fr/blog/puppet-openstack-achievements-during-newton-cycle/ I can't describe how much I liked to be PTL during the last 18

Re: [openstack-dev] [puppet] Puppet OpenStack PTL non-candidacy

2016-09-09 Thread Cody Herriges
On September 9, 2016 at 10:15:09 AM, Emilien Macchi (emil...@redhat.com) wrote: On Fri, Sep 9, 2016 at 1:12 PM, Cody Herriges <o...@herriges.org> wrote:  > On September 9, 2016 at 9:08:56 AM, Emilien Macchi (emil...@redhat.com)  > wrote:  >  > Hi,  >  > I wrote a little