Re: [openstack-dev] [horizon] Minimum Unit Test Coverage

2015-07-22 Thread Rajat Vig
Hi Rob I agree. Enforcing a minimum level of coverage as a start is awesome. I must add though keeping it at 100% and breaking the build has almost never worked in practice for me. Keeping a slightly lower level ~98% is slightly more pragmatic. Also, the currently low coverages will have to be

Re: [openstack-dev] [Horizon]Let's take care of our integration tests

2015-09-11 Thread Rajat Vig
Is there any documentation to run the tests locally? Doing ./run_tests.sh --only-selenium skips a lot of tests. Is that the recommended way? -Rajat On Thu, Sep 10, 2015 at 3:54 PM, David Lyle wrote: > I completely agree about monitoring for integration test failures and >

Re: [openstack-dev] [Horizon] Updating XStatic packages

2016-01-06 Thread Rajat Vig
I did update some of the low hanging packages where the upgrades seemed safe to do and noted the patch numbers in the same EtherPad. I wasn't sure what to mark the effort against. So I created some bugs. Should it be a blueprint? -Rajat On Wed, Jan 6, 2016 at 2:18 AM, Rob Cresswell (rcresswe)

Re: [openstack-dev] [Horizon] naming of Javascript bits

2016-01-06 Thread Rajat Vig
Richard My preference is the same as what you've got there. Fully namespaced Services and Controller allow for better reusability and possibly maintainability. If all "deleteService" were named just that, it'll be mighty confusing to use it in other places. With regards to tying the folder path