Re: [openstack-dev] [devstack] Compute-node-only installation fails
On Wed, 11 Feb 2015 17:27:19 + "Daniel P. Berrange" wrote: > On Wed, Feb 11, 2015 at 08:32:31AM -0800, Clark Boylan wrote: > > On Wed, Feb 11, 2015, at 08:18 AM, Alexander Schmidt wrote: > > > Hi Daniel, > > > > > > with your recent change[1] to error handling in stack.sh, compute > > > node only installations via devstack fail because there is > > > no database selected. A database should not be required on > > > compute nodes. > > > > > > Was this done intentionally? lib/database explicitly says: > > > > > > # If ``DATABASE_TYPE`` is unset here no database was selected > > > # This is not an error as multi-node installs will do this on the > > > compute nodes > > > > > > [1] https://review.openstack.org/#/c/149288/ > > > > > > Regards, > > > Alex > > > > We have been setting DATABASE_TYPE [0] so did not notice. Seems > > like a reasonable work around for now and does not install a > > database server (the enabled services list seems to do that). If > > the intended behavior is to not need to set DATABASE_TYPE we should > > probably revert the devstack change then update devstack-gate's > > compute node localrc generation to remove DATABASE_TYPE so that > > breakage of the behavior has a chance of being caught early. > > I posted a revert review for my change > >https://review.openstack.org/#/c/154966/ > Thanks, working fine again now. Regards, Alex > Regards, > Daniel __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [devstack] Compute-node-only installation fails
On 02/11/2015 11:32 AM, Clark Boylan wrote: > On Wed, Feb 11, 2015, at 08:18 AM, Alexander Schmidt wrote: >> Hi Daniel, >> >> with your recent change[1] to error handling in stack.sh, compute >> node only installations via devstack fail because there is >> no database selected. A database should not be required on >> compute nodes. >> >> Was this done intentionally? lib/database explicitly says: >> >> # If ``DATABASE_TYPE`` is unset here no database was selected >> # This is not an error as multi-node installs will do this on the >> compute nodes >> >> [1] https://review.openstack.org/#/c/149288/ >> >> Regards, >> Alex >> >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > We have been setting DATABASE_TYPE [0] so did not notice. Seems like a > reasonable work around for now and does not install a database server > (the enabled services list seems to do that). If the intended behavior > is to not need to set DATABASE_TYPE we should probably revert the > devstack change then update devstack-gate's compute node localrc > generation to remove DATABASE_TYPE so that breakage of the behavior has > a chance of being caught early. > > [0] > http://logs.openstack.org/79/136179/5/experimental/check-tempest-dsvm-aiopcpu/6f5193e/logs/10.209.161.148-subnode/localrc.txt.gz Agree, the fix should be setting a default value. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [devstack] Compute-node-only installation fails
On Wed, Feb 11, 2015 at 08:32:31AM -0800, Clark Boylan wrote: > On Wed, Feb 11, 2015, at 08:18 AM, Alexander Schmidt wrote: > > Hi Daniel, > > > > with your recent change[1] to error handling in stack.sh, compute > > node only installations via devstack fail because there is > > no database selected. A database should not be required on > > compute nodes. > > > > Was this done intentionally? lib/database explicitly says: > > > > # If ``DATABASE_TYPE`` is unset here no database was selected > > # This is not an error as multi-node installs will do this on the > > compute nodes > > > > [1] https://review.openstack.org/#/c/149288/ > > > > Regards, > > Alex > > We have been setting DATABASE_TYPE [0] so did not notice. Seems like a > reasonable work around for now and does not install a database server > (the enabled services list seems to do that). If the intended behavior > is to not need to set DATABASE_TYPE we should probably revert the > devstack change then update devstack-gate's compute node localrc > generation to remove DATABASE_TYPE so that breakage of the behavior has > a chance of being caught early. I posted a revert review for my change https://review.openstack.org/#/c/154966/ Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [devstack] Compute-node-only installation fails
On Wed, Feb 11, 2015, at 08:18 AM, Alexander Schmidt wrote: > Hi Daniel, > > with your recent change[1] to error handling in stack.sh, compute > node only installations via devstack fail because there is > no database selected. A database should not be required on > compute nodes. > > Was this done intentionally? lib/database explicitly says: > > # If ``DATABASE_TYPE`` is unset here no database was selected > # This is not an error as multi-node installs will do this on the > compute nodes > > [1] https://review.openstack.org/#/c/149288/ > > Regards, > Alex > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev We have been setting DATABASE_TYPE [0] so did not notice. Seems like a reasonable work around for now and does not install a database server (the enabled services list seems to do that). If the intended behavior is to not need to set DATABASE_TYPE we should probably revert the devstack change then update devstack-gate's compute node localrc generation to remove DATABASE_TYPE so that breakage of the behavior has a chance of being caught early. [0] http://logs.openstack.org/79/136179/5/experimental/check-tempest-dsvm-aiopcpu/6f5193e/logs/10.209.161.148-subnode/localrc.txt.gz Clark __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [devstack] Compute-node-only installation fails
On Wed, Feb 11, 2015 at 05:18:35PM +0100, Alexander Schmidt wrote: > Hi Daniel, > > with your recent change[1] to error handling in stack.sh, compute > node only installations via devstack fail because there is > no database selected. A database should not be required on > compute nodes. > > Was this done intentionally? lib/database explicitly says: > > # If ``DATABASE_TYPE`` is unset here no database was selected > # This is not an error as multi-node installs will do this on the > compute nodes > > [1] https://review.openstack.org/#/c/149288/ No, obviously that side effect was definitely not intentional. I had a setup where I needed a database but had forgotten to enable one, and was just trying to get devstack to detect this upfront. I didn'tmean to break the valid use case of not having a database at all in the scenario you mention. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [devstack] Compute-node-only installation fails
Hi Daniel, with your recent change[1] to error handling in stack.sh, compute node only installations via devstack fail because there is no database selected. A database should not be required on compute nodes. Was this done intentionally? lib/database explicitly says: # If ``DATABASE_TYPE`` is unset here no database was selected # This is not an error as multi-node installs will do this on the compute nodes [1] https://review.openstack.org/#/c/149288/ Regards, Alex __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
