Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-24 Thread Duncan Thomas
On 17 April 2014 17:37, Deepak Shetty dpkshe...@gmail.com wrote: forgot to add, that for the above to work consistently, we definitely need to have a framework / mechanism in cinder where the driver is provided a function/callback to gracefully cleanup its mounts (or any other thing) during

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-17 Thread Deepak Shetty
Andrew, While i agree there is a thought to change/improve this in future, but the way it is today isn't acceptable, mainly bcos (as i said) the new serverIP is taken effect w/o service restart and if someone adds -o options.. even after service restart it doesn't take effect. Its confusing to

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-17 Thread Deepak Shetty
On Fri, Apr 11, 2014 at 8:25 PM, Eric Harney ehar...@redhat.com wrote: On 04/11/2014 07:54 AM, Deepak Shetty wrote: Hi, I am using the nfs and glusterfs driver as reference here. I see that load_shares_config is called everytime via _ensure_shares_mounted which I feel is incorrect

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-17 Thread Deepak Shetty
On Thu, Apr 17, 2014 at 10:00 PM, Deepak Shetty dpkshe...@gmail.com wrote: On Fri, Apr 11, 2014 at 8:25 PM, Eric Harney ehar...@redhat.com wrote: On 04/11/2014 07:54 AM, Deepak Shetty wrote: Hi, I am using the nfs and glusterfs driver as reference here. I see that

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-17 Thread Deepak Shetty
On Tue, Apr 15, 2014 at 4:14 PM, Duncan Thomas duncan.tho...@gmail.comwrote: On 11 April 2014 16:24, Eric Harney ehar...@redhat.com wrote: I suppose I should also note that if the plans in this blueprint are implemented the way I've had in mind, the main issue here about only loading

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-15 Thread Duncan Thomas
On 11 April 2014 16:24, Eric Harney ehar...@redhat.com wrote: I suppose I should also note that if the plans in this blueprint are implemented the way I've had in mind, the main issue here about only loading shares at startup time would be in place, so we may want to consider these questions

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-11 Thread Kerr, Andrew
Hi Deepak, I know that there are plans to completely change how NFS uses (or more accurately, will not use) the shares.conf file in the future. My guess is that a lot of this code will be changed in the near future during that rework. Andrew Kerr OpenStack QA Cloud Solutions Group NetApp

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-11 Thread Duncan Thomas
Hi Deepak Both of those (config being read repeatedly, and config not being applied if the share is already mounted) sound like bugs. Please file bug reports for both, with reproducers if possible. Thanks On 11 April 2014 12:54, Deepak Shetty dpkshe...@gmail.com wrote: Hi, I am using the

Re: [openstack-dev] [Cinder] XXXFSDriver: Query on usage of load_shares_config in ensure_shares_mounted

2014-04-11 Thread Eric Harney
On 04/11/2014 10:55 AM, Eric Harney wrote: On 04/11/2014 07:54 AM, Deepak Shetty wrote: Hi, I am using the nfs and glusterfs driver as reference here. I see that load_shares_config is called everytime via _ensure_shares_mounted which I feel is incorrect mainly because