Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-08 Thread Flavio Percoco
On 07/10/15 10:17 -0400, Doug Hellmann wrote: Excerpts from Flavio Percoco's message of 2015-10-07 16:50:16 +0900: On 06/10/15 23:36 +0900, Flavio Percoco wrote: >Greetings, > >Not so long ago, Erno started a thread[0] in this list to discuss the >abandon policies for patches that haven't been

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 06/10/15 12:11 -0400, Nikhil Komawar wrote: Overall I think this is a good idea and the time frame proposal also looks good. Few suggestions in-line. On 10/6/15 10:36 AM, Flavio Percoco wrote: Greetings, Not so long ago, Erno started a thread[0] in this list to discuss the abandon

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 06/10/15 17:54 +0200, Victor Stinner wrote: Hi, Le 06/10/2015 16:36, Flavio Percoco a écrit : Not so long ago, Erno started a thread[0] in this list to discuss the abandon policies for patches that haven't been updated in Glance. (...) 1) Lets do this on patches that haven't had any

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 06/10/15 23:36 +0900, Flavio Percoco wrote: Greetings, Not so long ago, Erno started a thread[0] in this list to discuss the abandon policies for patches that haven't been updated in Glance. I'd like to go forward and start following that policy with some changes that you can find below:

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 06/10/15 17:52 +0200, Julien Danjou wrote: On Tue, Oct 06 2015, Flavio Percoco wrote: I send patches to Glance from time to time, and they usually got 0 review for *weeks* (sometimes months, because, well there are no reviewers active in Glance, so: 1) Lets do this on patches that haven't

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 06/10/15 13:53 -0400, Doug Hellmann wrote: Excerpts from Flavio Percoco's message of 2015-10-06 23:36:53 +0900: Greetings, Not so long ago, Erno started a thread[0] in this list to discuss the abandon policies for patches that haven't been updated in Glance. I'd like to go forward and

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 07/10/15 11:12 +0200, Julien Danjou wrote: On Wed, Oct 07 2015, Flavio Percoco wrote: I'm not trying to solve the lack of reviews in Liberty by removing patches. What I'd like to do, though, is help to keep around patches that really matter. I think that's where you are making a mistake.

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Julien Danjou
On Wed, Oct 07 2015, Flavio Percoco wrote: > I'm not trying to solve the lack of reviews in Liberty by removing > patches. What I'd like to do, though, is help to keep around patches > that really matter. I think that's where you are making a mistake. They are contributors, like me or Victor,

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Bunting, Niall
> From: Julien Danjou [jul...@danjou.info] > Sent: 07 October 2015 10:12 > > On Wed, Oct 07 2015, Flavio Percoco wrote: > > > I'm not trying to solve the lack of reviews in Liberty by removing > > patches. What I'd like to do, though, is help to keep around patches > > that really matter. > > I

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Flavio Percoco
On 07/10/15 12:47 +, Bunting, Niall wrote: From: Julien Danjou [jul...@danjou.info] Sent: 07 October 2015 10:12 On Wed, Oct 07 2015, Flavio Percoco wrote: > I'm not trying to solve the lack of reviews in Liberty by removing > patches. What I'd like to do, though, is help to keep around

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-07 Thread Doug Hellmann
Excerpts from Flavio Percoco's message of 2015-10-07 16:50:16 +0900: > On 06/10/15 23:36 +0900, Flavio Percoco wrote: > >Greetings, > > > >Not so long ago, Erno started a thread[0] in this list to discuss the > >abandon policies for patches that haven't been updated in Glance. > > > >I'd like to

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Doug Hellmann
Excerpts from Flavio Percoco's message of 2015-10-06 23:36:53 +0900: > Greetings, > > Not so long ago, Erno started a thread[0] in this list to discuss the > abandon policies for patches that haven't been updated in Glance. > > I'd like to go forward and start following that policy with some >

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Nikhil Komawar
On 10/6/15 1:53 PM, Doug Hellmann wrote: > Excerpts from Flavio Percoco's message of 2015-10-06 23:36:53 +0900: >> Greetings, >> >> Not so long ago, Erno started a thread[0] in this list to discuss the >> abandon policies for patches that haven't been updated in Glance. >> >> I'd like to go

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Julien Danjou
On Tue, Oct 06 2015, Flavio Percoco wrote: I send patches to Glance from time to time, and they usually got 0 review for *weeks* (sometimes months, because, well there are no reviewers active in Glance, so: > 1) Lets do this on patches that haven't had any activity in the last 2 > months. This

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Victor Stinner
Hi, Le 06/10/2015 16:36, Flavio Percoco a écrit : Not so long ago, Erno started a thread[0] in this list to discuss the abandon policies for patches that haven't been updated in Glance. (...) 1) Lets do this on patches that haven't had any activity in the last 2 months. This adds one more month

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Nikhil Komawar
Overall I think this is a good idea and the time frame proposal also looks good. Few suggestions in-line. On 10/6/15 10:36 AM, Flavio Percoco wrote: > Greetings, > > Not so long ago, Erno started a thread[0] in this list to discuss the > abandon policies for patches that haven't been updated in

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Nikhil Komawar
This again becomes a part of the undefinied priority concept. It's hard to come up with a list of priorities all at the beginning of the cycle so, conflicting priority items may get missed every now and then. I hope the dashboard will help however, this is more of a people problem than a process

Re: [openstack-dev] [Glance] Process to clean up the review queue from non-active patches

2015-10-06 Thread Nikhil Komawar
I think Glance reviewer brandwidth is pretty low and the feedback time can be quite high. For specs, I had requested a section describing the core reviewer who will be vouching for your spec to be added to the spec itself. I think in general we have not seen anyone doing that strongly. If a spec