Re: [openstack-dev] [Neutron] Addressing unit tests broken by random PYTHONHASHSEED

2014-08-04 Thread Salvatore Orlando
Hi Henry,

Are the fixes pushed with patches [1], and [2], which amend tox.ini,
insufficient?

Salvatore

[1] https://review.openstack.org/#/c/109888/
[2] https://review.openstack.org/#/c/109729/


On 4 August 2014 20:42, Henry Gessau ges...@cisco.com wrote:

 Please see this bug:  https://launchpad.net/bugs/1348818

 I innocently assigned myself to this bug for Neutron. However, there are a
 very large number of Neutron unit tests that are broken by random hash
 seeds.
 I think multiple people should work on fixing the tests.

 We don't want to have multiple people doing the same fixes simultaneously,
 so
 I have created an etherpad[1] to list the broken tests and allow people to
 sign up for fixing them. Please read the instructions carefully.

 This is not urgent work for Neutron for Juno. Please prioritize other work
 first. However, there are several low-hanging-fruit fixes in the list,
 which
 may be good for new developers. Some of them are not so trivial though, so
 be
 careful.

 [1] https://etherpad.openstack.org/p/neutron-random-hashseed

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] Addressing unit tests broken by random PYTHONHASHSEED

2014-08-04 Thread Henry Gessau
Salvatore Orlando sorla...@nicira.com wrote:
 Hi Henry,
 
 Are the fixes pushed with patches [1], and [2], which amend tox.ini, 
 insufficient?
 
 Salvatore
 
 [1] https://review.openstack.org/#/c/109888/

This is for functional tests, not unit tests. Subtle difference. :)

 [2] https://review.openstack.org/#/c/109729/

This masks the errors by brute-forcing the hash to zero, which preserves
current behaviour. If we want to (and we do, eventually) remove this
work-around, then we need to fix all the broken test cases. The etherpad has
all the details.

 
 
 On 4 August 2014 20:42, Henry Gessau ges...@cisco.com
 mailto:ges...@cisco.com wrote:
 
 Please see this bug:  https://launchpad.net/bugs/1348818
 
 I innocently assigned myself to this bug for Neutron. However, there are a
 very large number of Neutron unit tests that are broken by random hash 
 seeds.
 I think multiple people should work on fixing the tests.
 
 We don't want to have multiple people doing the same fixes 
 simultaneously, so
 I have created an etherpad[1] to list the broken tests and allow people to
 sign up for fixing them. Please read the instructions carefully.
 
 This is not urgent work for Neutron for Juno. Please prioritize other work
 first. However, there are several low-hanging-fruit fixes in the list, 
 which
 may be good for new developers. Some of them are not so trivial though, 
 so be
 careful.
 
 [1] https://etherpad.openstack.org/p/neutron-random-hashseed
 
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org 
 mailto:OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 
 
 
 
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev