Re: [openstack-dev] [nova] Changes toComputeVirtAPI.wait_for_instance_event

2018-04-11 Thread Andreas Scheuring
Looks good IMO.

---
Andreas Scheuring (andreas_s)



On 11. Apr 2018, at 15:46, Eric Fried  wrote:

Jichen was able to use this information immediately, to great benefit
[1].  (If those paying attention could have a quick look at that to make
sure he used it right, it would be appreciated; I'm not an expert here.)

[1]
https://review.openstack.org/#/c/527658/31..32/nova/virt/zvm/guest.py@192

On 04/10/2018 09:06 PM, Chen CH Ji wrote:
> Thanks for your info ,really helpful
> 
> Best Regards!
> 
> Kevin (Chen) Ji 纪 晨
> 
> Engineer, zVM Development, CSTL
> Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com
> Phone: +86-10-82451493
> Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian
> District, Beijing 100193, PRC
> 
> Inactive hide details for Andreas Scheuring ---04/10/2018 10:19:21
> PM---Yes, that’s how it works! ---Andreas Scheuring ---04/10/2018
> 10:19:21 PM---Yes, that’s how it works! ---
> 
> From: Andreas Scheuring 
> To: "OpenStack Development Mailing List (not for usage questions)"
> 
> Date: 04/10/2018 10:19 PM
> Subject: Re: [openstack-dev] [nova] Changes
> toComputeVirtAPI.wait_for_instance_event
> 
> 
> 
> 
> 
> Yes, that’s how it works!
> 
> ---
> Andreas Scheuring (andreas_s)
> 
> 
> 
> On 10. Apr 2018, at 16:05, Matt Riedemann <_mriedemos@gmail.com_
> <mailto:mriede...@gmail.com>> wrote:
> 
> On 4/9/2018 9:57 PM, Chen CH Ji wrote:
> 
>Could you please help to share whether this kind of event is
>sent by neutron-server or neutron agent ? I searched neutron code
>from [1][2] this means the agent itself need tell neutron server
>the device(VIF) is up then neutron server will send notification
>to nova through REST API and in turn consumed by compute node?
>
> [1]_https://github.com/openstack/neutron/tree/master/neutron/notify_port_active_direct_
>
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_neutron_tree_master_neutron_notify-5Fport-5Factive-5Fdirect&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=bVXQK6rjkLdaaYUVCaIBHJYOMGQ2tPGg1bKNkOSmF7Q&e=>
>
> [2]_https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/rpc.py#L264_
>
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_neutron_blob_master_neutron_plugins_ml2_rpc.py-23L264&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=9Ywu8bHp7mWDkIviZpAXCFjiYo7RfSREeg0ze3iPedA&e=>
> 
> 
> I believe the neutron agent is the one that is getting (or polling) the
> information from the underlying network backend when VIFs are plugged or
> unplugged from a host, then route that information via RPC to the
> neutron server which then sends an os-server-external-events request to
> the compute REST API, which then routes the event information down to
> the nova-compute host where the instance is currently running.
> 
> -- 
> 
> Thanks,
> 
> Matt
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: _OpenStack-dev-request@lists.openstack.org_
> <mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe_
> __http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev_
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openstack.org_cgi-2Dbin_mailman_listinfo_openstack-2Ddev&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=z2jOgMD7B3XFoNsUHTtIO6hWKYXH-Dm4L4P0-u-oSSw&e=>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openstack.org_cgi-2Dbin_mailman_listinfo_openstack-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=z2jOgMD7B3XFoNsUHTtIO6hWKYXH-Dm4L4P0-u-oSSw&e=
> 
> 
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
&

Re: [openstack-dev] [nova] Changes toComputeVirtAPI.wait_for_instance_event

2018-04-11 Thread Eric Fried
Jichen was able to use this information immediately, to great benefit
[1].  (If those paying attention could have a quick look at that to make
sure he used it right, it would be appreciated; I'm not an expert here.)

[1]
https://review.openstack.org/#/c/527658/31..32/nova/virt/zvm/guest.py@192

On 04/10/2018 09:06 PM, Chen CH Ji wrote:
> Thanks for your info ,really helpful
> 
> Best Regards!
> 
> Kevin (Chen) Ji 纪 晨
> 
> Engineer, zVM Development, CSTL
> Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com
> Phone: +86-10-82451493
> Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian
> District, Beijing 100193, PRC
> 
> Inactive hide details for Andreas Scheuring ---04/10/2018 10:19:21
> PM---Yes, that’s how it works! ---Andreas Scheuring ---04/10/2018
> 10:19:21 PM---Yes, that’s how it works! ---
> 
> From: Andreas Scheuring 
> To: "OpenStack Development Mailing List (not for usage questions)"
> 
> Date: 04/10/2018 10:19 PM
> Subject: Re: [openstack-dev] [nova] Changes
> toComputeVirtAPI.wait_for_instance_event
> 
> 
> 
> 
> 
> Yes, that’s how it works!
> 
> ---
> Andreas Scheuring (andreas_s)
> 
> 
> 
> On 10. Apr 2018, at 16:05, Matt Riedemann <_mriedemos@gmail.com_
> <mailto:mriede...@gmail.com>> wrote:
> 
> On 4/9/2018 9:57 PM, Chen CH Ji wrote:
> 
> Could you please help to share whether this kind of event is
> sent by neutron-server or neutron agent ? I searched neutron code
> from [1][2] this means the agent itself need tell neutron server
> the device(VIF) is up then neutron server will send notification
> to nova through REST API and in turn consumed by compute node?
> 
> [1]_https://github.com/openstack/neutron/tree/master/neutron/notify_port_active_direct_
> 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_neutron_tree_master_neutron_notify-5Fport-5Factive-5Fdirect&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=bVXQK6rjkLdaaYUVCaIBHJYOMGQ2tPGg1bKNkOSmF7Q&e=>
> 
> [2]_https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/rpc.py#L264_
> 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_neutron_blob_master_neutron_plugins_ml2_rpc.py-23L264&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=9Ywu8bHp7mWDkIviZpAXCFjiYo7RfSREeg0ze3iPedA&e=>
> 
> 
> I believe the neutron agent is the one that is getting (or polling) the
> information from the underlying network backend when VIFs are plugged or
> unplugged from a host, then route that information via RPC to the
> neutron server which then sends an os-server-external-events request to
> the compute REST API, which then routes the event information down to
> the nova-compute host where the instance is currently running.
> 
> -- 
> 
> Thanks,
> 
> Matt
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: _OpenStack-dev-request@lists.openstack.org_
> <mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe_
> __http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev_
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openstack.org_cgi-2Dbin_mailman_listinfo_openstack-2Ddev&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=z2jOgMD7B3XFoNsUHTtIO6hWKYXH-Dm4L4P0-u-oSSw&e=>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openstack.org_cgi-2Dbin_mailman_listinfo_openstack-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=z2jOgMD7B3XFoNsUHTtIO6hWKYXH-Dm4L4P0-u-oSSw&e=
> 
> 
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] Changes toComputeVirtAPI.wait_for_instance_event

2018-04-10 Thread Chen CH Ji
Thanks for your info ,really helpful

Best Regards!

Kevin (Chen) Ji 纪 晨

Engineer, zVM Development, CSTL
Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
Phone: +86-10-82451493
Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District,
Beijing 100193, PRC



From:   Andreas Scheuring 
To: "OpenStack Development Mailing List (not for usage questions)"

Date:   04/10/2018 10:19 PM
Subject:    Re: [openstack-dev] [nova] Changes
    toComputeVirtAPI.wait_for_instance_event



Yes, that’s how it works!

---
Andreas Scheuring (andreas_s)



On 10. Apr 2018, at 16:05, Matt Riedemann  wrote:

On 4/9/2018 9:57 PM, Chen CH Ji wrote:
  Could you please help to share whether this kind of event is sent by
  neutron-server or neutron agent ? I searched neutron code
  from [1][2] this means the agent itself need tell neutron server the
  device(VIF) is up then neutron server will send notification
  to nova through REST API and in turn consumed by compute node?
  [1]
  
https://github.com/openstack/neutron/tree/master/neutron/notify_port_active_direct

  [2]
  
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/rpc.py#L264

I believe the neutron agent is the one that is getting (or polling) the
information from the underlying network backend when VIFs are plugged or
unplugged from a host, then route that information via RPC to the neutron
server which then sends an os-server-external-events request to the compute
REST API, which then routes the event information down to the nova-compute
host where the instance is currently running.

--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openstack.org_cgi-2Dbin_mailman_listinfo_openstack-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=tIntFpZ0ffp-_h5CsqN1I9tv64hW2xugxBXaxDn7Z_I&s=z2jOgMD7B3XFoNsUHTtIO6hWKYXH-Dm4L4P0-u-oSSw&e=



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] Changes toComputeVirtAPI.wait_for_instance_event

2018-04-10 Thread Andreas Scheuring
Yes, that’s how it works!

---
Andreas Scheuring (andreas_s)



On 10. Apr 2018, at 16:05, Matt Riedemann  wrote:

On 4/9/2018 9:57 PM, Chen CH Ji wrote:
> Could you please help to share whether this kind of event is sent by 
> neutron-server or neutron agent ? I searched neutron code
> from [1][2] this means the agent itself need tell neutron server the 
> device(VIF) is up then neutron server will send notification
> to nova through REST API and in turn consumed by compute node?
> [1]https://github.com/openstack/neutron/tree/master/neutron/notify_port_active_direct
> [2]https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/rpc.py#L264

I believe the neutron agent is the one that is getting (or polling) the 
information from the underlying network backend when VIFs are plugged or 
unplugged from a host, then route that information via RPC to the neutron 
server which then sends an os-server-external-events request to the compute 
REST API, which then routes the event information down to the nova-compute host 
where the instance is currently running.

-- 

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] Changes toComputeVirtAPI.wait_for_instance_event

2018-04-10 Thread Matt Riedemann

On 4/9/2018 9:57 PM, Chen CH Ji wrote:
Could you please help to share whether this kind of event is sent by 
neutron-server or neutron agent ? I searched neutron code
from [1][2] this means the agent itself need tell neutron server the 
device(VIF) is up then neutron server will send notification

to nova through REST API and in turn consumed by compute node?

[1]https://github.com/openstack/neutron/tree/master/neutron/notify_port_active_direct
[2]https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/rpc.py#L264


I believe the neutron agent is the one that is getting (or polling) the 
information from the underlying network backend when VIFs are plugged or 
unplugged from a host, then route that information via RPC to the 
neutron server which then sends an os-server-external-events request to 
the compute REST API, which then routes the event information down to 
the nova-compute host where the instance is currently running.


--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] Changes toComputeVirtAPI.wait_for_instance_event

2018-04-09 Thread Chen CH Ji
Could you please help to share whether this kind of event is sent by
neutron-server or neutron agent ? I searched neutron code
from [1][2]  this means the agent itself need tell neutron server the
device(VIF) is up then neutron server will send notification
to nova through REST API and in turn consumed by compute node?

[1]
https://github.com/openstack/neutron/tree/master/neutron/notify_port_active_direct
[2]
https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/rpc.py#L264


Best Regards!

Kevin (Chen) Ji 纪 晨

Engineer, zVM Development, CSTL
Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
Phone: +86-10-82451493
Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District,
Beijing 100193, PRC



From:   Matt Riedemann 
To: "OpenStack Development Mailing List (not for usage questions)"

Date:   04/10/2018 01:56 AM
Subject:[openstack-dev] [nova] Changes to
ComputeVirtAPI.wait_for_instance_event



As part of a bug fix [1], the internal
ComputeVirtAPI.wait_for_instance_event interface is changing to no
longer accept event names that are strings, and will now require the
(name, tag) tuple form which all of the in-tree virt drivers are already
using.

If you have an out of tree driver that uses this interface, heads up
that you'll need to be using the tuple form if you are not already doing
so.

[1]
https://urldefense.proofpoint.com/v2/url?u=https-3A__review.openstack.org_-23_c_558059_&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=yyfqhpyjmwq9aUO_EdyVhYZm-8zEDpEYxh2-hPu1kig&s=S5Asyhxw296d0rp-EOCg1VMsKcwVV39i1pGeqkobE2U&e=


--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openstack.org_cgi-2Dbin_mailman_listinfo_openstack-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=8sI5aZT88Uetyy_XsOddbPjIiLSGM-sFnua3lLy2Xr0&m=yyfqhpyjmwq9aUO_EdyVhYZm-8zEDpEYxh2-hPu1kig&s=H3OLArdYuR4ARtKwSqJaI3ctLkqJSAVhldfty7GL9lo&e=




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev