Re: [openstack-dev] [nova] gate testing with lvm imagebackend
On 05/10/2016 04:47 PM, Matt Riedemann wrote: On 5/10/2016 5:14 PM, Chris Friesen wrote: For what it's worth, we've got internal patches to enable cold migration and resize for LVM-backed instances. We've also got a proof of concept to enable thin-provisioned LVM to get rid of the huge wipe-volume-on-deletion cost. I'd be interested if you want to push the changes up as a WIP, then we could run my devstack-gate change with your series as a dependency and see what kind of fallout there is. I also need to check of there are any tempest tests that test resize/migrate from a volume-backed instance and if those are passing on this. I finally got around to massaging our "allow resize/migration for LVM-backed instances" patch into something that should work on upstream: https://review.openstack.org/#/c/337334 I'm not totally sure the logic is 100% correct, haven't worked through all the cases. It's possible there are still some assumptions in there based on our configuration. Let me know what you think...maybe this could be O-release material? Chris __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] gate testing with lvm imagebackend
On 5/10/2016 4:51 PM, Matt Riedemann wrote: For the libvirt imagebackend refactor that mdbooth is working on, I have a POC devstack-gate change which runs with the lvm imagebackend in the libvirt driver [1]. The test results are mostly happy except for anything related to migrate (including resize to same host) [2][3]. That's because we're not testing with boot from volume [4]. This is a weird capability wrinkle that is not clear from the API, you'll only find out that you can't migrate/resize on this host that's using lvm when it fails. We can't even disable this in tempest really since there isn't a flag for 'only-supports-resize-for-volume-backed-instances'. So this job would just have to disable any tests that have anything to do with resize/migrate, which kind of sucks since that's what we wanted to test going into the libvirt imagebackend refactor. Anyway, I'm dumping this before leaving for the day, maybe others have some ideas here. [1] https://review.openstack.org/#/c/314744/ [2] http://logs.openstack.org/44/314744/3/check/gate-tempest-dsvm-neutron-full/57a083b/logs/testr_results.html.gz [3] http://logs.openstack.org/44/314744/3/check/gate-tempest-dsvm-neutron-full/57a083b/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-05-10_20_36_07_446 [4] https://github.com/openstack/nova/blob/00eccf56d01f4945ab46f246ab4fe751375b39be/nova/virt/libvirt/driver.py#L6960 Just to give an update on this. The tempest change to add a volume-backed resize test is merged. It turns out we had a bug with our Rbd image backend in libvirt that the test exposed, but that's fixed now. I've got a change up to add an LVM image backend job to Nova's experimental queue [1]. It has a dependency on a devstack change to ignore clearing volumes during the job run and a dependency on a Nova change for our blacklist regex of tests that won't pass - the non-volume-backed resize tests. Once we get this job in we can run it on-demand on the libvirt storage refactor series, or any other change in the libvirt driver code that touches the LVM paths. [1] https://review.openstack.org/#/c/316298/ -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] gate testing with lvm imagebackend
On 05/10/2016 04:47 PM, Matt Riedemann wrote: On 5/10/2016 5:14 PM, Chris Friesen wrote: On 05/10/2016 03:51 PM, Matt Riedemann wrote: For the libvirt imagebackend refactor that mdbooth is working on, I have a POC devstack-gate change which runs with the lvm imagebackend in the libvirt driver [1]. The test results are mostly happy except for anything related to migrate (including resize to same host) [2][3]. That's because we're not testing with boot from volume [4]. This is a weird capability wrinkle that is not clear from the API, you'll only find out that you can't migrate/resize on this host that's using lvm when it fails. We can't even disable this in tempest really since there isn't a flag for 'only-supports-resize-for-volume-backed-instances'. So this job would just have to disable any tests that have anything to do with resize/migrate, which kind of sucks since that's what we wanted to test going into the libvirt imagebackend refactor. For what it's worth, we've got internal patches to enable cold migration and resize for LVM-backed instances. We've also got a proof of concept to enable thin-provisioned LVM to get rid of the huge wipe-volume-on-deletion cost. Pretty sure we'd be happy to contribute these if there is interest. Last time I brought up some of these there didn't seem to be much. I'd be interested if you want to push the changes up as a WIP, then we could run my devstack-gate change with your series as a dependency and see what kind of fallout there is. I'll start the ball rolling...I'm in the middle of something so might take some time. Chris __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] gate testing with lvm imagebackend
On 5/10/2016 5:47 PM, Matt Riedemann wrote: On 5/10/2016 5:14 PM, Chris Friesen wrote: On 05/10/2016 03:51 PM, Matt Riedemann wrote: For the libvirt imagebackend refactor that mdbooth is working on, I have a POC devstack-gate change which runs with the lvm imagebackend in the libvirt driver [1]. The test results are mostly happy except for anything related to migrate (including resize to same host) [2][3]. That's because we're not testing with boot from volume [4]. This is a weird capability wrinkle that is not clear from the API, you'll only find out that you can't migrate/resize on this host that's using lvm when it fails. We can't even disable this in tempest really since there isn't a flag for 'only-supports-resize-for-volume-backed-instances'. So this job would just have to disable any tests that have anything to do with resize/migrate, which kind of sucks since that's what we wanted to test going into the libvirt imagebackend refactor. For what it's worth, we've got internal patches to enable cold migration and resize for LVM-backed instances. We've also got a proof of concept to enable thin-provisioned LVM to get rid of the huge wipe-volume-on-deletion cost. Pretty sure we'd be happy to contribute these if there is interest. Last time I brought up some of these there didn't seem to be much. Chris __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev I'd be interested if you want to push the changes up as a WIP, then we could run my devstack-gate change with your series as a dependency and see what kind of fallout there is. I also need to check of there are any tempest tests that test resize/migrate from a volume-backed instance and if those are passing on this. We don't have any Tempest tests which test resizing a volume-backed instance. We did have two redundant resize tests though, so I changed one of those to use a volume-backed instance [1]. If that works I'll add it as a dependency for my d-g test patch. [1] https://review.openstack.org/#/c/314816/ -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] gate testing with lvm imagebackend
On 5/10/2016 5:14 PM, Chris Friesen wrote: On 05/10/2016 03:51 PM, Matt Riedemann wrote: For the libvirt imagebackend refactor that mdbooth is working on, I have a POC devstack-gate change which runs with the lvm imagebackend in the libvirt driver [1]. The test results are mostly happy except for anything related to migrate (including resize to same host) [2][3]. That's because we're not testing with boot from volume [4]. This is a weird capability wrinkle that is not clear from the API, you'll only find out that you can't migrate/resize on this host that's using lvm when it fails. We can't even disable this in tempest really since there isn't a flag for 'only-supports-resize-for-volume-backed-instances'. So this job would just have to disable any tests that have anything to do with resize/migrate, which kind of sucks since that's what we wanted to test going into the libvirt imagebackend refactor. For what it's worth, we've got internal patches to enable cold migration and resize for LVM-backed instances. We've also got a proof of concept to enable thin-provisioned LVM to get rid of the huge wipe-volume-on-deletion cost. Pretty sure we'd be happy to contribute these if there is interest. Last time I brought up some of these there didn't seem to be much. Chris __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev I'd be interested if you want to push the changes up as a WIP, then we could run my devstack-gate change with your series as a dependency and see what kind of fallout there is. I also need to check of there are any tempest tests that test resize/migrate from a volume-backed instance and if those are passing on this. -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] gate testing with lvm imagebackend
On 05/10/2016 03:51 PM, Matt Riedemann wrote: For the libvirt imagebackend refactor that mdbooth is working on, I have a POC devstack-gate change which runs with the lvm imagebackend in the libvirt driver [1]. The test results are mostly happy except for anything related to migrate (including resize to same host) [2][3]. That's because we're not testing with boot from volume [4]. This is a weird capability wrinkle that is not clear from the API, you'll only find out that you can't migrate/resize on this host that's using lvm when it fails. We can't even disable this in tempest really since there isn't a flag for 'only-supports-resize-for-volume-backed-instances'. So this job would just have to disable any tests that have anything to do with resize/migrate, which kind of sucks since that's what we wanted to test going into the libvirt imagebackend refactor. For what it's worth, we've got internal patches to enable cold migration and resize for LVM-backed instances. We've also got a proof of concept to enable thin-provisioned LVM to get rid of the huge wipe-volume-on-deletion cost. Pretty sure we'd be happy to contribute these if there is interest. Last time I brought up some of these there didn't seem to be much. Chris __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
