Re: [openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?
Hi, In the V2 API the attach interface is a blocking operation. This is problematic. I posted a patch for the V3 to be non blocking - https://review.openstack.org/#/c/103094/ (as we cannot break existing API¹s). I would prefer that you do not remove the V3 api. I am not sure what you mean by saying that we are not parodying to Neutron. The Neutron API is invoked when the attach is done, that is, a Neutron port needs to be created. Thanks Gary On 10/2/14, 11:57 PM, Matt Riedemann mrie...@linux.vnet.ibm.com wrote: The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1]. Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist? Was this just an oversight? If so, please allow me to delete it. :) [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2 014.2.rc1#n310 [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compu te/plugins/v3/attach_interfaces.py?id=2014.2.rc1 -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?
On 10/2/2014 10:30 PM, Christopher Yeoh wrote: On Thu, 02 Oct 2014 15:57:55 -0500 Matt Riedemann mrie...@linux.vnet.ibm.com wrote: The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1]. Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist? Was this just an oversight? If so, please allow me to delete it. :) The proxying work was not done in Juno due to time constraints, but I think we should be able to cover it early in Kilo (most of the patches are pretty much ready). To have a V2.1 which is functionality equivalent to V2 (allowing us to remove the V2 code) we have to implement proxying. Chris [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2014.2.rc1#n310 [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/attach_interfaces.py?id=2014.2.rc1 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev OK I didn't realize proxying to neutron was back on the table for v2.1 but that makes sense. So the floating IP extensions will be back too I assume? And that probably means that this [1] proxy patch for quota usages and limits is back on the table for v2.1? If so, I can probably restore that and start cleaning it up. Back when work stopped on it in Icehouse I think the thing that was left to do was add it to the base Network API so we didn't have the is_neutron checks in the compute API code (so this will work like the show_ports and list_ports network APIs - implemented by the neutronv2 API and not implemented by the nova-network API). [1] https://review.openstack.org/#/c/43822/ -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?
If you can add and delete interfaces it seems like being able to list them is useful. You can get the info you need from the networks list when you get the instance, but “nova interface-list” seems like a useful addition if we have “interface-attach” and “interface-detach”, so in this case I think I would suggest that we leave the proxying in and implement it for nova-network as well. I was looking for an anologue with cinder but it looks like we have a volume-attach and volume-detach there without a volume-list server command so if people want to kill it I’m ok with that too. Vish On Oct 2, 2014, at 2:43 PM, Matt Riedemann mrie...@linux.vnet.ibm.com wrote: On 10/2/2014 4:34 PM, Vishvananda Ishaya wrote: os-attach-interfacees is actually a a forward port of: http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/attach_interfaces.py which is a compute action that is valid for both nova-network and neutron: http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n2991 On Oct 2, 2014, at 1:57 PM, Matt Riedemann mrie...@linux.vnet.ibm.com wrote: The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1]. Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist? Was this just an oversight? If so, please allow me to delete it. :) [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2014.2.rc1#n310 [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/attach_interfaces.py?id=2014.2.rc1 -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev OK so create/delete call the compute_api to attach/detach, but show and index are calling the network_api on port methods which are neutron only, so I guess that's what I'm talking about as far as removing. Personally I don't think it hurts anything, but I'm getting mixed signals about the stance on neutron proxying in the v2.1 API. -- Thanks, Matt Riedemann signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?
os-attach-interfacees is actually a a forward port of: http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/attach_interfaces.py which is a compute action that is valid for both nova-network and neutron: http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n2991 On Oct 2, 2014, at 1:57 PM, Matt Riedemann mrie...@linux.vnet.ibm.com wrote: The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1]. Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist? Was this just an oversight? If so, please allow me to delete it. :) [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2014.2.rc1#n310 [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/attach_interfaces.py?id=2014.2.rc1 -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?
On 10/2/2014 4:34 PM, Vishvananda Ishaya wrote: os-attach-interfacees is actually a a forward port of: http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/attach_interfaces.py which is a compute action that is valid for both nova-network and neutron: http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n2991 On Oct 2, 2014, at 1:57 PM, Matt Riedemann mrie...@linux.vnet.ibm.com wrote: The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1]. Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist? Was this just an oversight? If so, please allow me to delete it. :) [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2014.2.rc1#n310 [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/attach_interfaces.py?id=2014.2.rc1 -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev OK so create/delete call the compute_api to attach/detach, but show and index are calling the network_api on port methods which are neutron only, so I guess that's what I'm talking about as far as removing. Personally I don't think it hurts anything, but I'm getting mixed signals about the stance on neutron proxying in the v2.1 API. -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?
On Thu, 02 Oct 2014 15:57:55 -0500 Matt Riedemann mrie...@linux.vnet.ibm.com wrote: The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1]. Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist? Was this just an oversight? If so, please allow me to delete it. :) The proxying work was not done in Juno due to time constraints, but I think we should be able to cover it early in Kilo (most of the patches are pretty much ready). To have a V2.1 which is functionality equivalent to V2 (allowing us to remove the V2 code) we have to implement proxying. Chris [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2014.2.rc1#n310 [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/attach_interfaces.py?id=2014.2.rc1 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
