Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

To anyone who cares, I made a try to use kombu 2.5 (specifically its reconnecting logic), with oslo.messaging (which uses kombu's reconnecting logic after kilo). No matter whether heartbeat is enabled or not, there are truly many problems. NoneType Error [1], eg. I have to manually backport

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

Thank you for pointing this out, dims. I didn't notice this process of openstack. But i wonder how do you find the relationship between that bot's commit and the global requirements commit. And sileht, from this commit

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

apporc, I do a git blame on global-requirements.txt to figure that out. I'll let @sileht answer the other one :) -- dims On Wed, Oct 28, 2015 at 3:15 PM, me,apporc wrote: > Thank you for pointing this out, dims. I didn't notice this process of > openstack. But i

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

Le 2015-10-27 04:22, me,apporc a écrit : But i found in the changelog history of kombu [1], heartbeat support was added in version 2.5.0, so what's the point for ">= 3.0.7". Thanks. The initial heartbeat implementation have some critical issues for oslo.messaging that was fixed since kombu

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

Thank you for the explanation, Mehdi. About the "critical issues" mentioned in the commits, as i understand: [1] seems just socket timeout issue, and admins can adjust those kernel params themselves. [2] and [3] truly a problem about the heartbeat implementation, but it says the fix is a part of

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

[1] seems just socket timeout issue, and admins can adjust those kernel params themselves. Yes, but if you trick kernel settings, like putting very low tcp keepalive values, you don't need to have/enable heartbeat. [2] and [3] truly a problem about the heartbeat implementation, but it

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

Thanks again. This kombu >=3.0.7 requirement is added in commit 5b9fb6980220dbfa18bac4c3231d57efb493ebf0, which is from a Bot with no reason. As i see, we are directly requiring amqp >=1.4.0 in requirement.txt from commit 0c954cffa2f3710acafa79f01b958a8955823640 on. So maybe there is no need to

Re: [openstack-dev] [oslo.messaging] Why the needed version of kombu to support heartbeat is >=3.0.7

"Bot with No reason" <<< Not really accurate. The process in openstack is to update global requirements first and then bot proposes the update to different projects. So please look at https://github.com/openstack/requirements/commit/c7f69afd6af56e8f7956c6fa0bea8fd776151fe6 for the commit which