Re: [openstack-dev] [vmware][nova] Refactor reseries rebased

2014-09-02 Thread Michael Still
By which John means "generally trying to avoid filling".

Michael

On Tue, Sep 2, 2014 at 10:52 AM, John Garbutt  wrote:
> On 2 September 2014 15:27, Matthew Booth  wrote:
>> We've been playing a game recently between oslo.vmware and the refactor
>> series where a patch from the refactor series goes in, requiring a
>> rebase of oslo.vmware daily. After a brief discussion with garyk earlier
>> I decided to head that off by rebasing the refactor series on top of
>> oslo.vmware, which has been sat in the integrated queue in the gate for
>> over 5 hours now. i.e. Whether it succeeds or fails, it will now go in
>> before anything else.
>>
>> Unfortunately, in doing that I have had to lose +2 +A on 4 refactor
>> series patches. I made a note of who had approved them:
>>
>> https://review.openstack.org/#/c/109754/
>> Brian Elliott +2
>> John Garbutt +2 +A
>>
>> https://review.openstack.org/#/c/109755/
>> Daniel Berrange +2
>> Andrew Laski +2
>> John Garbutt +2 +A
>>
>> https://review.openstack.org/#/c/114817/
>> Brian Elliott +2
>> Andrew Laski +2
>> John Garbutt +2 +A
>>
>> https://review.openstack.org/#/c/117467/
>> Brian Elliott +2
>> Andrew Laski +2
>> John Garbutt +2 +A
>>
>> These patches have been lightly touched to resolve merge conflicts with
>> the oslo.vmware integration, but no more. If people could take another
>> quick look I'd be very grateful.
>
> If stuff was approved, and you have rebased, just reach out for cores
> on (or us) on IRC. Thats a general invite, particularly at this FF
> sort of time.
>
> Generally trying to to fill the ML with review requests.
>
> Cheers,
> John
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Rackspace Australia

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [vmware][nova] Refactor reseries rebased

2014-09-02 Thread John Garbutt
On 2 September 2014 15:27, Matthew Booth  wrote:
> We've been playing a game recently between oslo.vmware and the refactor
> series where a patch from the refactor series goes in, requiring a
> rebase of oslo.vmware daily. After a brief discussion with garyk earlier
> I decided to head that off by rebasing the refactor series on top of
> oslo.vmware, which has been sat in the integrated queue in the gate for
> over 5 hours now. i.e. Whether it succeeds or fails, it will now go in
> before anything else.
>
> Unfortunately, in doing that I have had to lose +2 +A on 4 refactor
> series patches. I made a note of who had approved them:
>
> https://review.openstack.org/#/c/109754/
> Brian Elliott +2
> John Garbutt +2 +A
>
> https://review.openstack.org/#/c/109755/
> Daniel Berrange +2
> Andrew Laski +2
> John Garbutt +2 +A
>
> https://review.openstack.org/#/c/114817/
> Brian Elliott +2
> Andrew Laski +2
> John Garbutt +2 +A
>
> https://review.openstack.org/#/c/117467/
> Brian Elliott +2
> Andrew Laski +2
> John Garbutt +2 +A
>
> These patches have been lightly touched to resolve merge conflicts with
> the oslo.vmware integration, but no more. If people could take another
> quick look I'd be very grateful.

If stuff was approved, and you have rebased, just reach out for cores
on (or us) on IRC. Thats a general invite, particularly at this FF
sort of time.

Generally trying to to fill the ML with review requests.

Cheers,
John

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev