Re: [openstack-dev] Testing before sending for review
On 2013-10-23 04:29, Rosa, Andrea (HP Cloud Services) wrote: Hi 2. Before submitting the new patch for review it's better to run unit tests (tox -epy27) and pep8 check (tox -epep8) Instead of pep8 I think you should run flake8 we moved to that some months ago[1]. Usually I find always useful to test my changes in devstack. Regards -- Andrea Rosa [1] http://lists.openstack.org/pipermail/openstack-dev/2013-May/009178.html tox -epep8 actually runs flake8. It just wasn't renamed to avoid breaking people's existing workflow. Also, just running "tox" will run all of the appropriate tests for your environment, which is probably what you want before pushing changes. Specifying -e is useful while you're working on something though so you don't have to run flake8 every time. -Ben ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Testing before sending for review
Hi >On 23.10.2013 11:29, Rosa, Andrea (HP Cloud Services) wrote: >> Usually I find always useful to test my changes in devstack. > >How do you do that? I think the devstack does not always contain up to date >codebase does it, so what would be the point in testing changes on the old >code? With devstack you can decide which code you want to install and run playing with the configuration files: 1 you can define to reclone your devstack installation using the latest trunk code every time you run stack.sh, to do that add RECLONE=yes option [1] 2 you can specify which branch you want to use [2] Hope this helps -- Andrea Rosa [1] http://devstack.org/localrc.html [2] http://devstack.org/stackrc.html ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Testing before sending for review
Hey, On 23.10.2013 11:29, Rosa, Andrea (HP Cloud Services) wrote: Usually I find always useful to test my changes in devstack. How do you do that? I think the devstack does not always contain up to date codebase does it, so what would be the point in testing changes on the old code? Thanks for the reply. -- Marek Denis [marek.de...@cern.ch] ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Testing before sending for review
Hi > 2. Before submitting the new patch for review it's better to run unit tests > (tox -epy27) and pep8 check (tox -epep8) Instead of pep8 I think you should run flake8 we moved to that some months ago[1]. Usually I find always useful to test my changes in devstack. Regards -- Andrea Rosa [1] http://lists.openstack.org/pipermail/openstack-dev/2013-May/009178.html ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Testing before sending for review
To clarify point #2: always check the logs to see the cause of the failure. If it's due to a bug in the submitted code, fix and resubmit. If it's caused by something else, check if it's an open bug, and if not open a new bug report - in either case, do "recheck bug #". If it's really not caused by any bug, do "recheck no bug". Thanks, Avishay From: Eugene Nikanorov To: OpenStack Development Mailing List , Date: 10/23/2013 12:07 PM Subject: Re: [openstack-dev] Testing before sending for review Hi, 1. It's not necessary to abandon your patch if it has failed jenkins tests. 2. Before submitting the new patch for review it's better to run unit tests (tox -epy27) and pep8 check (tox -epep8) Integration testing is being done by check-tempest-devstack-vm-neutron* suites and some of them fail from time to time due to other known bugs. In case of such failure just put 'recheck no bug' in general review comment, (or 'recheck bug xx' if you know which bug you are hitting). Sometimes integration test failures are caused by the patch itself, in this case you need to analyze the logs and fix the code. But I believe it's not your case. Thanks, Eugene. On Wed, Oct 23, 2013 at 9:38 AM, S Sridhar wrote: Hi All, I posted a review earlier - https://review.openstack.org/#/c/53160/, which failed Jenkins test. I realized that changes required in other files too. I 'Abandoned Changes' so that I can post review set again. I have made the changes now, but want to test them before sending for review. It is suggested in https://wiki.openstack.org/wiki/GerritWorkflow to run 'tox' before checking in. Is this enough or there are any other steps I need to follow for unit testing? Please suggest. Regards Sridhar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Testing before sending for review
Hi, 1. It's not necessary to abandon your patch if it has failed jenkins tests. 2. Before submitting the new patch for review it's better to run unit tests (tox -epy27) and pep8 check (tox -epep8) Integration testing is being done by check-tempest-devstack-vm-neutron* suites and some of them fail from time to time due to other known bugs. In case of such failure just put 'recheck no bug' in general review comment, (or 'recheck bug xx' if you know which bug you are hitting). Sometimes integration test failures are caused by the patch itself, in this case you need to analyze the logs and fix the code. But I believe it's not your case. Thanks, Eugene. On Wed, Oct 23, 2013 at 9:38 AM, S Sridhar wrote: > Hi All, > > I posted a review earlier - https://review.openstack.org/#/c/53160/, > which failed Jenkins test. I realized that changes required in other files > too. I 'Abandoned Changes' so that I can post review set again. I have > made the changes now, but want to test them before sending for review. > > It is suggested in https://wiki.openstack.org/wiki/GerritWorkflow to run > 'tox' before checking in. Is this enough or there are any other steps I > need to follow for unit testing? > > Please suggest. > > Regards > Sridhar > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
