Re: [Openstack] Swift on Webob-1.2 anyone?
On Wed, 09 May 2012 18:18:52 +0200 Ionuț Arțăriși iartar...@suse.cz wrote: It would be great to have it on 1.2b3, though. I think I had a pretty good start, here: https://review.openstack.org/7569 Not sure if I am doing the right thing, however. I split it like this: - Proxy server does a lot of processing and checking of the keys, so it needs to operate on byte strings, not the unicode (it may be fixed up, but I found it too hard). So, I just force unicode strings that are actually UTF-8 with each UTF-8 byte taking 1 unicode symbol. This is totally wrong, but it works. If someone can cook up an alternative patch, I'm all for it. Note that this permits Proxy to work on keys that are binary garbage, in case of e.g. LFS. - Object, Container, and Account are fixed up to work on Unicode in Pythonic way. One side effect of this is that they ONLY accept UTF-8 encoded keys now. It appears that they verify such, so I am not breaking any compatibility, I think. Would love to see any fixes, objections, additions, etc. -- Pete ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Swift on Webob-1.2 anyone?
Hi Pete, On Wed, May 9, 2012 at 4:45 AM, Pete Zaitcev zait...@redhat.com wrote: on adapting Swift for WebOb 1.2 and if a patch is available somewhere. I see Ionut fixed lp:984042, but clearly it wasn't enough. If nobody's done it yet, I suppose I could take a swing at it. New webob I started doing that sometime ago (~6 month) and abandoned working on it since some of the changes were pretty intrusive[1] with the way swift works and webob 1.2 was in beta at that time (and still is). The challenge if you are taking a stab at it would probably be to support webob 1.1* and 1.2 at the same time in the code. Cheers, Chmouel. [1] I can't remember the details. ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Swift on Webob-1.2 anyone?
On 05/09/2012 05:45 AM, Pete Zaitcev wrote: I ran .unittests on a box with python-webob-1.2b3 and it throws left and right: errors=72, failures=6. I'm wondering if anyone is working on adapting Swift for WebOb 1.2 and if a patch is available somewhere. I see Ionut fixed lp:984042, but clearly it wasn't enough. If nobody's done it yet, I suppose I could take a swing at it. New webob is required to address the S3-with-colon problem lp:936998. -- Pete We started at 1.2b3, but saw too many failing unittests so we downgraded to 1.1.1 which we now have working. It would be great to have it on 1.2b3, though. -Ionuț ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Swift on Webob-1.2 anyone?
On Wed, 9 May 2012 16:14:48 +0100 Chmouel Boudjnah chmo...@chmouel.com wrote: The challenge if you are taking a stab at it would probably be to support webob 1.1* and 1.2 at the same time in the code. I noticed that too. 1.1.1 made some intermediate choices that are difficult to reconcile, namely throwing warnings that break tests. The None values that they sprinkled over 1.2 ironically help. Fedora is likely to ship 1.1 in F17, so I guess I have to deal with it somehow. What a pain. -- Pete ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
