[Openvpn-devel] [PATCH] build: t_client re-addition

2012-05-28 Thread Alon Bar-Lev
Adding integration tests that needs and/or manual intervention to make check is not something that should be encouraged. Tiered of arguing. But if you add this, at least use the following. --- tests/Makefile.am| 11 ++- tests/t_client.sh.in | 13 - 2 files changed, 14

Re: [Openvpn-devel] build revolution lost t_client test?

2012-05-28 Thread Gert Doering
Hi, On Mon, May 28, 2012 at 03:08:11PM +0300, Samuli Seppänen wrote: > I don't really care what the make target is called. It could even be an > entirely different target. Buildslaves could easily run "make check" > followed by "make root-check", "make connection-test" or whatever. If > nobody out

Re: [Openvpn-devel] build revolution lost t_client test?

2012-05-28 Thread Samuli Seppänen
Il 28.05.2012 10:52, Gert Doering ha scritto: > Hi > > On Sun, May 27, 2012 at 11:36:57PM +0300, Alon Bar-Lev wrote: >> t_client.sh requires root/sudo privileges. >> "make check" should not assume any special privilege. >> Because of this it is removed from "make check". >> You can still run this b

[Openvpn-devel] [PATCH] OCC ping

2012-05-28 Thread SamB
Hi,   this is simple patch implementing internal openvpn ping over OCC channel.   Important difference of OCC ping (OCC_PING) to existing one is that this one is replied on the other side of the channel (with OCC_PING_REPLY),   thus making it possible to configure clients and server ping and ping-

Re: [Openvpn-devel] build revolution lost t_client test?

2012-05-28 Thread Gert Doering
Hi On Sun, May 27, 2012 at 11:36:57PM +0300, Alon Bar-Lev wrote: > t_client.sh requires root/sudo privileges. > "make check" should not assume any special privilege. > Because of this it is removed from "make check". > You can still run this by hand or we can add special target such as > "make roo