[Openvpn-devel] [PATCH] Declare Windows version of openvpn_execve() before use

2018-10-24 Thread selva . nair
From: Selva Nair commit bf97c00f7dba441b504881f38e40afcbb610a39f moved the generic openvpn_execve() to run_command.c and made it static. But the Windows version is still in win32.c and is called from run_command.c Fix by declaring the function in win32.h Signed-off-by: Selva Nair --- This is

Re: [Openvpn-devel] Slow outbound network speed for Windows Server 2016 only via the OpenVPN tunnel

2018-10-24 Thread Rostyslav Maryliak
Dear tincanteksup, Yes, Samuli is correct. It is impossible to install the older version of TAP adapter (NDIS 5) on Windows Server 2016 On Wed, Oct 24, 2018 at 3:20 PM Samuli Seppänen wrote: > Hi, > > If I recall correctly, NDIS 5 support was dropped in Windows 8 or early > Windows 10.

[Openvpn-devel] [PATCH applied] Re: Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Gert Doering
Your patch has been applied to the master branch. Make OpenBSD great^w green again! (Tested before pushing :) ) (I have amended the comments according to the discussion) commit 4ce1a9b6b3ae0be32a3d999c5bc93731c64d7bbb Author: Lev Stipakov Date: Tue Oct 23 17:51:28 2018 +0300 Wrap

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Selva Nair
Hi, On Wed, Oct 24, 2018 at 9:00 AM David Sommerseth wrote: > > On 24/10/18 14:39, Selva Nair wrote: > > On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli wrote: > >> > >> Hi, > >> > > > > > > Also there is a misplaced and mismatched comment added to > > buffer.c that says > > > > +/*

Re: [Openvpn-devel] Adding Google Analytics code to Trac?

2018-10-24 Thread Emmanuel Deloget
Hello, On Wed, Oct 24, 2018 at 3:02 PM Jan Just Keijser wrote: > > Hi, > > On 24/10/18 13:47, Samuli Seppänen wrote: > > Hi, > > > > The OpenVPN Inc. webmaster would like to add Google Analytics to > > community.openvpn.net, i.e. our Trac wiki/bug tracker. I said we need to > > consult the

Re: [Openvpn-devel] Adding Google Analytics code to Trac?

2018-10-24 Thread Christian Rank
On 10/24/18 1:47 PM, Samuli Seppänen wrote: Hi, The OpenVPN Inc. webmaster would like to add Google Analytics to community.openvpn.net, i.e. our Trac wiki/bug tracker. I said we need to consult the community first because GA can be seen as a form of spying. Here's our webmaster's view on this

Re: [Openvpn-devel] Adding Google Analytics code to Trac?

2018-10-24 Thread Jan Just Keijser
Hi, On 24/10/18 13:47, Samuli Seppänen wrote: Hi, The OpenVPN Inc. webmaster would like to add Google Analytics to community.openvpn.net, i.e. our Trac wiki/bug tracker. I said we need to consult the community first because GA can be seen as a form of spying. Here's our webmaster's view on

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread David Sommerseth
On 24/10/18 14:39, Selva Nair wrote: > On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli wrote: >> >> Hi, >> >> On 23/10/18 22:51, Lev Stipakov wrote: >>> From: Lev Stipakov >>> >>> Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added >>> vswprintf() call which turned to me missing in OpenBSD

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Selva Nair
On Wed, Oct 24, 2018 at 6:23 AM Antonio Quartulli wrote: > > Hi, > > On 23/10/18 22:51, Lev Stipakov wrote: > > From: Lev Stipakov > > > > Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added > > vswprintf() call which turned to me missing in OpenBSD 4.9. > > > > Since that call is inside

Re: [Openvpn-devel] Adding Google Analytics code to Trac?

2018-10-24 Thread David Sommerseth
On 24/10/18 13:47, Samuli Seppänen wrote: > Hi, > > The OpenVPN Inc. webmaster would like to add Google Analytics to > community.openvpn.net, i.e. our Trac wiki/bug tracker. I said we need to > consult the community first because GA can be seen as a form of spying. > Here's our webmaster's view

Re: [Openvpn-devel] Slow outbound network speed for Windows Server 2016 only via the OpenVPN tunnel

2018-10-24 Thread Samuli Seppänen
Hi, If I recall correctly, NDIS 5 support was dropped in Windows 8 or early Windows 10. Tap-windows uses NDIS 5, so it almost certainly does not work on Windows Server 2016. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock Il 24/10/18 15:09,

Re: [Openvpn-devel] Slow outbound network speed for Windows Server 2016 only via the OpenVPN tunnel

2018-10-24 Thread tincanteksup
Hi, a completely different approach .. On the Forum somebody claimed that the old Tap Adaptor works better than the new one on W2012r2. https://forums.openvpn.net/viewtopic.php?f=6=27288#p81973 Could you test that ? Thanks tct On 03/10/2018 16:15, Rostyslav Maryliak wrote: Dear OpenVPN

[Openvpn-devel] Summary of the community meeting (Wed, 24th Oct 2018)

2018-10-24 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wednesday 24th October 2018 Time: 11:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: The

[Openvpn-devel] Fwd: [PATCH] Remove deprecated --compat-x509-names and --no-name-remapping

2018-10-24 Thread Jonathan K. Bullard
Sorry, sent to Steffan but not the list: -- Forwarded message - From: Jonathan K. Bullard Date: Wed, Oct 24, 2018 at 7:00 AM Subject: Re: [Openvpn-devel] [PATCH] Remove deprecated --compat-x509-names and --no-name-remapping To: Steffan Karger Hi, The actual option name is

Re: [Openvpn-devel] [PATCH 3/4] Add gc_arena to struct argv to save allocations

2018-10-24 Thread David Sommerseth
On 19/10/18 17:56, David Sommerseth wrote: > From: Heiko Hund > > With the private gc_arena we do not have to allocate the strings > found during parsing again, since we know the arena they are > allocated in is valid as long as the argv vector is. > > Signed-off-by: Heiko Hund > --- >

Re: [Openvpn-devel] [PATCH] Wrap openvpn_swprintf into Windows define

2018-10-24 Thread Antonio Quartulli
Hi, On 23/10/18 22:51, Lev Stipakov wrote: > From: Lev Stipakov > > Commit 43a5a4f3b4e411419639c195fee8a76495fdc88e added > vswprintf() call which turned to me missing in OpenBSD 4.9. > > Since that call is inside openvpn_swprintf() function which > is only used by Windows, wrap that function

Re: [Openvpn-devel] [PATCH 2/4] argv: do fewer memory re-allocations

2018-10-24 Thread David Sommerseth
On 19/10/18 17:56, David Sommerseth wrote: > From: Heiko Hund > > Prevent the re-allocations of memory when the internal argv grows > beyond 2 and 4 arguments by initially allocating argv to hold up to > 7 (+ trailing NULL) pointers. > > While at it rename argv_reset to argv_free to actually

[Openvpn-devel] [PATCH] Remove deprecated --compat-x509-names and --no-name-remapping

2018-10-24 Thread Steffan Karger
As promised, remove these options for OpenVPN 2.5. If a user still uses these, print an error that the user should update it's configuration. Just printing a warning would cause much more confusing errors, somewhere in middle of a failed connection attempt because the (non-compat) names no longer

Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2018-10-24 Thread David Sommerseth
On 19/10/18 17:56, David Sommerseth wrote: > From: Heiko Hund > > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). > > It modifies the format string and inserts marks to

[Openvpn-devel] [PATCH v3] Make compression asymmetric by default and add warnings

2018-10-24 Thread Arne Schwabe
This commit introduces the allow-compression option that allow changing the new default to the previous default or to a stricter version. Warning are not generated in the post option check (options_postprocess_mutate) since these warnings should also be shown on pushed options. Patch V2: fix