Re: [Openvpn-devel] [PATCH] BUILD: MSVC: enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation

2021-12-31 Thread Илья Шипицин
For the record https://github.com/microsoft/binskim/issues/508 On Fri, Dec 31, 2021, 8:35 PM Илья Шипицин wrote: > CETCOMPAT is not supported for ARM. > Regarding other arch I do not have particular opinion, I'm fine with > either props or vcxproj approach > > On Fri, Dec 31, 2021, 5:09 PM Lev

Re: [Openvpn-devel] [PATCH] BUILD: MSVC: enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation

2021-12-31 Thread Илья Шипицин
CETCOMPAT is not supported for ARM. Regarding other arch I do not have particular opinion, I'm fine with either props or vcxproj approach On Fri, Dec 31, 2021, 5:09 PM Lev Stipakov wrote: > Hi, > > Sorry for the delay. > > 1) Was it really necessary to modify .props? I enabled this via >

Re: [Openvpn-devel] [PATCH] BUILD: MSVC: enable the Control-flow Enforcement Technology (CET) Shadow Stack mitigation

2021-12-31 Thread Lev Stipakov
Hi, Sorry for the delay. 1) Was it really necessary to modify .props? I enabled this via Linker->Advanced->CET Shadow Stack Compatible and only .vcxproj files got modified. 2) I think we could enable it for all binaries (openvpn/openvpnmsica/openvpnserv/tapctl) for ARM64/WIn32/x64 Release

[Openvpn-devel] [PATCH applied] Re: Remove pointless do_init_frame_tls function

2021-12-31 Thread Gert Doering
Not tested beyond "make check", change is trivial enough. Your patch has been applied to the master branch. commit 2b6fcdc0280c9e56c4ce0f348cab7511b809b839 Author: Arne Schwabe Date: Tue Dec 7 18:02:01 2021 +0100 Remove pointless do_init_frame_tls function Signed-off-by: Arne

[Openvpn-devel] [PATCH applied] Re: Rework occ link-mtu calculation

2021-12-31 Thread Gert Doering
Acked-by: Gert Doering Code looks reasonably, and comes with an extensive test suite - so I did not test "does it configure the same link-mtu for all possible combinations as the code before that". I did test some basic stuff (TLS/BF-CBC/SHA1, TLS/AES-256-GCM, TLS/none/none) and it did produce