[Openvpn-devel] [PATCH] add support for --dns option

2022-03-08 Thread Heiko Hund
As a first step towards DNS configuration in openvpn and a unified way to push DNS related settings to clients in v2 and v3, this commit adds support for parsing the new --dns option. Later commits will add support for setting up DNS on different platforms. For now, --dns and DNS related

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-03-08 Thread Arne Schwabe
Am 08.03.22 um 15:45 schrieb Kristof Provost via Openvpn-devel: On 8 Mar 2022, at 15:23, Antonio Quartulli wrote: On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: I've had to add a lot of '|| defined(TARGET_FREEBSD)', and I think the code could be a bit cleaner if we'd make these

Re: [Openvpn-devel] [PATCH 2/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-03-08 Thread Kristof Provost via Openvpn-devel
On 8 Mar 2022, at 15:36, Antonio Quartulli wrote: > On 08/03/2022 15:29, Kristof Provost wrote: >> Theoretically I’d prefer to use the OS header, but I can certainly see the >> upside of not having that dependency. We’ll always have to do the runtime >> check (dco_available()) anyway, so I can

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-03-08 Thread Kristof Provost via Openvpn-devel
On 8 Mar 2022, at 15:23, Antonio Quartulli wrote: > On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: >> I've had to add a lot of '|| defined(TARGET_FREEBSD)', and I think the >> code could be a bit cleaner if we'd make these calls conditional only on >> defined(ENABLE_DCO), and

Re: [Openvpn-devel] [PATCH 2/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-03-08 Thread Antonio Quartulli
Hi, On 08/03/2022 15:29, Kristof Provost wrote: It’s not really too relevant either way for FreeBSD, because the header contains very little information. It’s mostly only the ioctl numbers. There are no structures shared between the kernel and user land. Instead we use nvlists (name/value

Re: [Openvpn-devel] [PATCH 2/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-03-08 Thread Kristof Provost via Openvpn-devel
On 8 Mar 2022, at 15:16, Antonio Quartulli wrote: > Hi Kristof, > > A quick question for you, see below > > On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: >> --- a/configure.ac >> +++ b/configure.ac >> @@ -787,7 +787,20 @@ dnl >> AC_DEFINE(ENABLE_DCO, 1, [Enable

Re: [Openvpn-devel] [PATCH DCO]: FreeBSD DCO support

2022-03-08 Thread Antonio Quartulli
Hi, On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: I've had to add a lot of '|| defined(TARGET_FREEBSD)', and I think the code could be a bit cleaner if we'd make these calls conditional only on defined(ENABLE_DCO), and instead expect every DCO implementation to provide them, if

Re: [Openvpn-devel] [PATCH 2/2] ovpn-dco: introduce FreeBSD data-channel offload support

2022-03-08 Thread Antonio Quartulli
Hi Kristof, A quick question for you, see below On 24/02/2022 17:55, Kristof Provost via Openvpn-devel wrote: --- a/configure.ac +++ b/configure.ac @@ -787,7 +787,20 @@ dnl AC_DEFINE(ENABLE_DCO, 1, [Enable data channel offload for Linux])