Re: [Openvpn-devel] [PATCH applied] Re: Improve signal handling using POSIX sigaction

2023-07-23 Thread Gert Doering
Hi, On Sun, Jul 23, 2023 at 10:46:17AM -0400, Selva Nair wrote: > Now I wish someone could review 2/2 of this patch-set. That's where further > potential loss of signal during signal-reset is avoided. Working on finding a vict^Wvolunteer :-) (I've briefly looked over 2/2 and didn't find anything

Re: [Openvpn-devel] [PATCH applied] Re: Improve signal handling using POSIX sigaction

2023-07-23 Thread Selva Nair
On Sun, Jul 23, 2023 at 5:28 AM Gert Doering wrote: > > The actual "change to POSIX ways" part of this is fairly trivial > and easy to understand :-) - though I do wonder why you're using > an extra variable for block_mask -> sa.sa_mask, and not using > sigfillset(&sa.sa_mask) - at least on BSD o

[Openvpn-devel] [PATCH applied] Re: Improve signal handling using POSIX sigaction

2023-07-23 Thread Gert Doering
Sorry for taking so long on this - it hit post-release fatigue... I did test this by running t_client test (which use signals to kill running openvpn) across all supported OSes, and server side tests on Linux, with and without DCO. Of course this is not really excercising the signal handling code