Re: [Openvpn-devel] [PATCH] Document that auth-user-pass may be inlined

2024-02-19 Thread Antonio Quartulli
Hi, On 19/02/2024 20:28, selva.n...@gmail.com wrote: From: Selva Nair Commits 7d48d31b, 39619b7f added support for inlining username and, optionally, password. Add a description of its usage in the man page. Change-Id: I7a1765661f7676eeba8016024080fd1026220ced Signed-off-by: Selva Nair Ack

[Openvpn-devel] [PATCH] Document that auth-user-pass may be inlined

2024-02-19 Thread selva . nair
From: Selva Nair Commits 7d48d31b, 39619b7f added support for inlining username and, optionally, password. Add a description of its usage in the man page. Change-Id: I7a1765661f7676eeba8016024080fd1026220ced Signed-off-by: Selva Nair --- Does this have to go through gerrit? doc/man-sections/c

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-02-19 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table .

[Openvpn-devel] [M] Change in openvpn[master]: Persist-key: enable persist-key option by default

2024-02-19 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/529?usp=email to review the following change. Change subject: Persist-key: enable persist-key option by defaul

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-19 Thread Gert Doering
Hi, On Mon, Feb 19, 2024 at 02:23:08PM +0100, Antonio Quartulli wrote: > On 19/02/2024 14:12, Gert Doering wrote: > > Maybe that would be a more reasonable approach here... get rid of the > > umbrella if(), and check individual bits inside. It seems to be a > > micro-optimization "skip this branc

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-19 Thread Antonio Quartulli
Hi, On 19/02/2024 14:12, Gert Doering wrote: Maybe that would be a more reasonable approach here... get rid of the umbrella if(), and check individual bits inside. It seems to be a micro-optimization "skip this branch if we have no single feature active", while at least MSSFIX is active by defa

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-19 Thread Gert Doering
Hi, On Mon, Feb 19, 2024 at 02:08:56PM +0100, Antonio Quartulli wrote: > This said, I do believe this patch fixes these issues in one go as the new > PIP_OPT_MASK will match all the flags mentioned above. Yes, but then we do not need that if() anymore at all - if we go in there, no matter if we h

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-19 Thread Antonio Quartulli
Hi, On 16/02/2024 15:00, Antonio Quartulli wrote: Hi, On 15/02/2024 17:17, Gert Doering wrote: Hi, On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote:   if (buf->len > 0)   { -    /* - * The --passtos and --mssfix options require - * us to exa

[Openvpn-devel] [XS] Change in openvpn[master]: Route: remove incorrect routes on exit

2024-02-19 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/522?usp=email to look at the new patch set (#2). The following approvals got outdated and were rem

[Openvpn-devel] [XS] Change in openvpn[master]: Route: remove incorrect routes on exit

2024-02-19 Thread its_Giaan (Code Review)
its_Giaan has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/528?usp=email ) Change subject: Route: remove incorrect routes on exit .. Abandoned Duplicate with wrong change-id -- To view, visit http://gerrit.op