cron2 has uploaded a new patch set (#4) to the change originally created by
reynir. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Only schedule_exit() once
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )
Change subject: Only schedule_exit() once
..
Only schedule_exit() once
If an exit has already been scheduled we should not schedule it aga
Thanks :-) - this is mostly the same as v2, with a whitespace fix,
and remodeling receive_exit_message() to avoid -Werror failures
when comping without ENABLE_MANAGEMENT ("unused variable").
Tested on GHA, buildbots and the server testbed.
Your patch has been applied to the master and release/2.
From: Reynir Björnsson
If an exit has already been scheduled we should not schedule it again.
Otherwise, the exit signal is never emitted if the peer reschedules the
exit before the timeout occurs.
schedule_exit() now only takes the context as argument. The signal is
hard coded to SIGTERM, and t
Attention is currently required from: flichtenheld, reynir.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )
Change subject: Only schedule_exit() once
..
Patch Set 3: Code-R
Attention is currently required from: flichtenheld, reynir.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/555?usp=email )
Change subject: Only schedule_exit() once
..
Patch Set 3:
(1 co
Attention is currently required from: flichtenheld, plaisthos, reynir.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/555?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were remove
