Re: [Openvpn-devel] [PATCH] ssl: enable basic ecdsa

2013-11-12 Thread Alon Bar-Lev
On Tue, Nov 12, 2013 at 3:51 PM, Jan Just Keijser <janj...@nikhef.nl> wrote: > Alon Bar-Lev wrote: > > On Tue, Nov 12, 2013 at 1:37 PM, Jan Just Keijser <janj...@nikhef.nl> wrote: > > > there was actually a follow-up to this patch, which was sent to the > o

Re: [Openvpn-devel] [PATCH 2/2 v4] add API for plug-ins to write to openvpn log

2012-08-02 Thread Alon Bar-Lev
Thanks, although I think the extra macro is not required. Last thing I see is that you need to #include as va_list is used. And last style comment, I don't think use of enum for bit fields is common, better to simply #define the constants. On Thu, Aug 2, 2012 at 6:20 PM, Heiko Hund

Re: [Openvpn-devel] [PATCH 2/2 v2.2] add plugin_log() API to write to openvpn log

2012-08-02 Thread Alon Bar-Lev
And export vprintf variant as well, to allow wrapper. On Thu, Aug 2, 2012 at 1:02 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > This is how it should be done, no games with symbols and linkage. > > Please add printf style pragmas to the function. > > On Thu, Aug 2, 20

Re: [Openvpn-devel] [PATCH 2/2 fixed] add plugin_log() API to write to openvpn log

2012-08-01 Thread Alon Bar-Lev
On Wed, Aug 1, 2012 at 3:48 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 01 August 2012 15:27:01 Alon Bar-Lev wrote: >> How will it work on Windows? > > Good question. Can't it work on Windows? According to objdump openvpn.exe > exports all the symbo

Re: [Openvpn-devel] [PATCH 2/2 fixed] add plugin_log() API to write to openvpn log

2012-08-01 Thread Alon Bar-Lev
How will it work on Windows? Plugins should not require to be linked against anything. On Wed, Aug 1, 2012 at 2:57 PM, Heiko Hund wrote: > Some plugins want to add messages to the openvpn log file. The > plugin_log() API provides a way for them to do so. > > Signed-off-by:

Re: [Openvpn-devel] [PATCHv2 1/2] make non-blocking connect work on Windows

2012-07-18 Thread Alon Bar-Lev
I had time to look at the code, what I don't understand is how come we work none blocking and do not test for EWOULDBLOCK at other places... If I get it right, at least after send() we can get EWOULDBLOCK even if select() returned we have free buffers. On Wed, Jul 18, 2012 at 7:20 AM, Alon Bar

Re: [Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-07-18 Thread Alon Bar-Lev
Nobody disables the absolute path use. This patch permits relative use. On Wed, Jul 18, 2012 at 3:44 PM, Jonathan K. Bullard <jkbull...@gmail.com> wrote: > On Tue, Jun 26, 2012 at 1:05 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: >> >> Currently openvpn requires/en

Re: [Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-07-18 Thread Alon Bar-Lev
On Wed, Jul 18, 2012 at 4:34 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Hi! > > On Wed, Jul 18, 2012 at 2:44 PM, Heiko Hund <heiko.h...@sophos.com> wrote: >> Hi Alon >> >> On Tuesday 26 June 2012 20:05:02 Alon Bar-Lev wrote: >>> Currentl

Re: [Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-07-18 Thread Alon Bar-Lev
Hi! On Wed, Jul 18, 2012 at 2:44 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > Hi Alon > > On Tuesday 26 June 2012 20:05:02 Alon Bar-Lev wrote: >> Currently openvpn requires/endorses specifying full path in plugin >> parameter. > > Specifying a custom full p

Re: [Openvpn-devel] New build system questions

2012-07-18 Thread Alon Bar-Lev
On Wed, Jul 18, 2012 at 4:26 PM, David Sommerseth > Agreed, this sounds like a feature regression. > > Dynamic loading requires dlopen() and such (provided by libdl) and > when compiled non-static, all this dlopen() stuff happens > automatically, as the linker have instructed the binary what to

Re: [Openvpn-devel] [PATCH] don't treat socket related errors special anymore

2012-07-17 Thread Alon Bar-Lev
On Tue, Jul 17, 2012 at 6:15 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Tuesday 17 July 2012 18:11:25 Alon Bar-Lev wrote: >> #define EWOULDBLOCK WSAWOULDBLOCK > > EWOULDBLOCK is already defined in errno.h (also in Windows) and shouldn't be > redefined in my opinio

Re: [Openvpn-devel] [PATCH] don't treat socket related errors special anymore

2012-07-17 Thread Alon Bar-Lev
On Tue, Jul 17, 2012 at 6:09 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Tuesday 17 July 2012 17:25:25 Alon Bar-Lev wrote: >> Just I don't like the CONNECT_IN_PROGRESS. >> I think it is better to rebase first and then submit the >> CONNECT_IN_PROGRESS afterwards,

Re: [Openvpn-devel] [PATCH] don't treat socket related errors special anymore

2012-07-17 Thread Alon Bar-Lev
This is a great cleanup. Just I don't like the CONNECT_IN_PROGRESS. I think it is better to rebase first and then submit the CONNECT_IN_PROGRESS afterwards, I think it would be simpler to just compare to the two statuses. On Tue, Jul 17, 2012 at 4:57 PM, Heiko Hund wrote:

Re: [Openvpn-devel] OpenVPN 3.3_alpha2 build problem

2012-07-16 Thread Alon Bar-Lev
On Mon, Jul 16, 2012 at 11:24 PM, Jonathan K. Bullard wrote: >> Please try: >> >> ./configure CFLAGS="-Ixxx" LDFLAGS="-Lyyy" >> >> Should be simpler. > > > Thanks. Although > > LDFLAGS="-Lxxx -Lyyy -Lzzz" > > builds, but it causes config to output "checking for

Re: [Openvpn-devel] New build system questions

2012-07-16 Thread Alon Bar-Lev
On Mon, Jul 16, 2012 at 7:24 PM, Jonathan K. Bullard wrote: > I'm in the process of trying to build 2.3_alpha2 into Tunnelblick. It's slow > going because of my unfamiliarity with make/automake, etc. I have several > questions: > > (1) Is there a way to disable building

Re: [Openvpn-devel] [PATCH] make non-blocking connect work on Windows

2012-07-16 Thread Alon Bar-Lev
On Mon, Jul 16, 2012 at 12:42 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Monday 16 July 2012 12:12:24 Alon Bar-Lev wrote: >> On Mon, Jul 16, 2012 at 11:39 AM, Heiko Hund <heiko.h...@sophos.com> wrote: >> > On Friday 13 July 2012 20:00:49 Alon Bar-Lev wrote:

Re: [Openvpn-devel] [PATCH] make non-blocking connect work on Windows

2012-07-16 Thread Alon Bar-Lev
On Mon, Jul 16, 2012 at 11:39 AM, Heiko Hund <heiko.h...@sophos.com> wrote: > Hi Alon > > On Friday 13 July 2012 20:00:49 Alon Bar-Lev wrote: >> In my projects I always compare to the two values EWOULDBLOCK and >> EINPROGRESS and it works without much condi

Re: [Openvpn-devel] Openvpn-2.3_alpha2 and easy-rsa-2.2.0_master packages and packaging files published

2012-07-13 Thread Alon Bar-Lev
Hello Samuli, Why didn't you use rpmbuild -tb .tar.gz? And if you have changes in spec file you should probably add this with proper conditionals to the spec file within the appropriate package. There should be no external resource maintained. The debian packaging should also be integrated

Re: [Openvpn-devel] [PATCH] make non-blocking connect work on Windows

2012-07-13 Thread Alon Bar-Lev
Hello, In my projects I always compare to the two values EWOULDBLOCK and EINPROGRESS and it works without much conditionals. So simply do: --- if (status == EINPROGRESS || status == EWOULDBLOCK) --- Alon. On Fri, Jul 13, 2012 at 12:55 PM, Heiko Hund wrote: > > Instead

Re: [Openvpn-devel] OpenVPN 3.3_alpha2 build problem

2012-07-07 Thread Alon Bar-Lev
On Sat, Jul 7, 2012 at 5:39 PM, Jonathan K. Bullard wrote: >> Were does the lzo libraries and includes located? >> If these are not located at default search path of your compiler you >> should probably add: CFLAGS="-I" LDFLAGS="-L" to >> configure. > > > Thanks. So the

Re: [Openvpn-devel] OpenVPN 3.3_alpha2 build problem

2012-07-07 Thread Alon Bar-Lev
Hello, Were does the lzo libraries and includes located? If these are not located at default search path of your compiler you should probably add: CFLAGS="-I" LDFLAGS="-L" to configure. Alon. On Sat, Jul 7, 2012 at 5:21 PM, Jonathan K. Bullard wrote: > I'm trying to

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3_alpha2 released

2012-07-04 Thread Alon Bar-Lev
gt; 2.3_alpha2. It can be downloaded from here: > > <http://openvpn.net/index.php/open-source/downloads.html> > > The largest change in OpenVPN 2.3_alpha2 is the split into several > subprojects (thanks go to Alon Bar-Lev): > > - openvpn (the core project) > - tap-windo

Re: [Openvpn-devel] [PATCH] Incrementing version number of tap-windows to 9.9.1

2012-07-02 Thread Alon Bar-Lev
Hi, If you are not going to release, you should keep the _master or _beta or any other suffix. Alon. On Mon, Jul 2, 2012 at 5:27 PM, wrote: > From: Samuli Seppänen > > Tap-windows driver is now built using it's own buildsystem, whereas earlier it > was

Re: [Openvpn-devel] Build issues on ScientificLinux 6.2

2012-07-02 Thread Alon Bar-Lev
Libtool version please. Thanks On 7/2/12, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Hi Alon & al, > > Just tried to do a scratch build on SL6.2 from the git tree. > > -

Re: [Openvpn-devel] [PATCH] Fix --management-external-key in 2.3alpha

2012-06-28 Thread Alon Bar-Lev
On Thu, Jun 28, 2012 at 9:03 PM, Arne Schwabe <a...@rfc2549.org> wrote: > Am 28.06.12 19:58, schrieb Alon Bar-Lev: >> Hmmm I discussed this before in list... the whole external key >> should be modified... the management should be able to support >> certificate + k

Re: [Openvpn-devel] [PATCH] Fix --management-external-key in 2.3alpha

2012-06-28 Thread Alon Bar-Lev
Hmmm I discussed this before in list... the whole external key should be modified... the management should be able to support certificate + key, and key should probably not be limited to RSA only. I had plans to clean this one as well. On Thu, Jun 28, 2012 at 8:44 PM, Arne Schwabe

Re: [Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-06-26 Thread Alon Bar-Lev
On Tue, Jun 26, 2012 at 8:05 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Currently openvpn requires/endorses specifying full path in plugin > parameter. As build system already aware of plugin location, it is > possible to load plugin relative to this director

[Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-06-26 Thread Alon Bar-Lev
Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/Makefile.am |1 + src/openvpn/options.c |3 + src/openvpn/plugin.c| 102 +++ 3 files changed, 72 insertions(+), 34 deletions(-) diff --git a/src/openvpn/Makefile.am b/src/openvpn/Makef

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
On Tue, Jun 26, 2012 at 5:06 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: >> You are more than welcome to maintain the build system and do whatever you >> like. > > I'm not exactly su

Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
This removes the Linux from the help string. On Tue, Jun 26, 2012 at 5:03 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com&g

[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index d

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
On Tue, Jun 26, 2012 at 4:50 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:41:49PM +0300, Alon Bar-Lev wrote: >> This is exactly the reason why *ALL* plugins should be disabled by default. >> We are left with only Linux enabled... and

Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
If anyone here is opened minded - still. This shows that default should be "no" for all plugins. Distro maintainer should decide what to switch on. Anyway, this is my recommendation. On Tue, Jun 26, 2012 at 4:55 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > pam cannot be

[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index d

[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
pam cannot be compiled on *BSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index d

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
t;g...@greenie.muc.de> wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:02:06PM +0300, Alon Bar-Lev wrote: >> Both plugins cannot be compiled on Windows anyway. > > Can you auto-disable plugin-auth-pam for OpenBSD as well, please? > > We ran into this on the OpenBSD buildslave today - Op

[Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
Both plugins cannot be compiled on Windows anyway. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..7235a87 100644 --- a/configure.ac

Re: [Openvpn-devel] [PATCH] build: msvc: chdir with change drive to script location

2012-06-26 Thread Alon Bar-Lev
Please apply. https://github.com/alonbl/openvpn/commit/692c35a3cce6226dd36bbc6b9138a353d1d14634 On Sat, Apr 28, 2012 at 9:51 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> > --- >  msvc-build.bat |    1 + >  msvc-dev

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-06-26 Thread Alon Bar-Lev
Please apply. https://github.com/alonbl/openvpn/compare/master...unicode On Thu, May 3, 2012 at 8:47 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > On Thu, May 3, 2012 at 1:53 PM, Samuli Seppänen <sam...@openvpn.net> wrote: >> >>> On Thu, May 3, 2012

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-19 Thread Alon Bar-Lev
essing, to keep the same behaviour. >> >> When msg with M_SSLERR is issued, the program terminates... >> --- >> #define M_SSLERR  (M_FATAL | M_SSL) >> >>  if (flags & M_FATAL) >>    openvpn_exit (OPENVPN_EXIT_STATUS_ERROR); /* exit point */ >>

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-18 Thread Alon Bar-Lev
. If option is not given then the >>> default UI functions are called (for linux at console that means >>> prompt the user). >>> >>> (the SRK password is not really a secret. If you have it then you're >>> allowed to do operations  with the TPM chip. But yo

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-18 Thread Alon Bar-Lev
s > prompt the user). > > (the SRK password is not really a secret. If you have it then you're > allowed to do operations  with the TPM chip. But you have to supply > the tpm-sealed data when doing the operation. I've seen several > recommendations to just leave it blank) > &

Re: [Openvpn-devel] [V2.4 0/4] tun cleanups

2012-06-18 Thread Alon Bar-Lev
On Mon, Jun 18, 2012 at 9:21 PM, Arne Schwabe <a...@rfc2549.org> wrote: > Am 12.05.12 21:31, schrieb Alon Bar-Lev: >> Platform independent interface for tun provider. >> >> Split the long tun.c into platform specific files using >> tun_engine interface

[Openvpn-devel] [PATCH] cleanup: pkcs11.c: resolve wanings

2012-06-18 Thread Alon Bar-Lev
src/openvpn/pkcs11.c:794:2: warning: passing argument 1 of ‘pkcs11h_setPINPromptHook’ from incompatible pointer type Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/pkcs11.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/openvpn/pkcs11.c

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-18 Thread Alon Bar-Lev
Oh... And I forgot mentioning that the UI method should be solved, using the default is not something that is usable for openvpn. Can you please take care of this? Alon. On Mon, Jun 18, 2012 at 3:25 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Hello Thomas, > > I did not

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-17 Thread Alon Bar-Lev
is not statically linked? What about ENGINE_finish() at proper place? Thank you for your patience, Alon Bar-Lev. On Sun, Jun 17, 2012 at 11:53 PM, Thomas Habets <tho...@habets.se> wrote: > Hi. > > Need? No. I thought you preferred reusing the loaded/inited ENGINE > struct cached by exi

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-17 Thread Alon Bar-Lev
se openssl-tpm-engine > doesn't yet support user data being sent to the callback functions. > A patch for that on its way to them. > > Some more details: > http://blog.habets.pp.se/2012/02/TPM-backed-SSL > > Signed-off-by: Thomas Habets <hab...@google.com> > > > &g

Re: [Openvpn-devel] PATCH: SSL Engine support

2012-06-17 Thread Alon Bar-Lev
Hello, It is a good idea. But first, please remove the emacs stuff. Now, I see that the ENGINE_load_builtin_engines() is already called at crypto_openssl.c::crypto_init_lib_engine, is there any require to duplicate this? There is already "engine" option, available only to polarssl, it can

Re: [Openvpn-devel] RHEL's rpmbuild needs slight modification to build from tarball from openvpn-2.3-alpha1.tar.gz

2012-06-15 Thread Alon Bar-Lev
You are correct. This was fixed in master. On Fri, Jun 15, 2012 at 2:23 AM, George Alexander wrote: > Hi everyone, I was building an rpm the other day of the latest release (it > looks great, can't wait to try it out) and noticed a lil problem: It doesn't > like

Re: [Openvpn-devel] ENABLE_PF and config.h breakage

2012-06-14 Thread Alon Bar-Lev
Right. config.h should be included in all C sources never in .h file, it is also not protected for multiple includes. Don't know why the polarssl had this, as syshead used to perform this in the past so it should not have existed also in the past. Thanks, Alon. On Thu, Jun 14, 2012 at 5:44 PM,

Re: [Openvpn-devel] PolarSSL 1.1.0 support?

2012-06-07 Thread Alon Bar-Lev
Hello, Build system should only care about the interface, not the "quality" of the dependency. So if we are built OK with >=1.1.0 than this should be the boundary. Thanks, Alon. On Thu, Jun 7, 2012 at 12:35 PM, Frank de Brabander wrote: > Maybe this should actually be

[Openvpn-devel] [PATCH] build: support =polarssl-1.1.0

2012-06-07 Thread Alon Bar-Lev
Repoted-by: Samuli Seppänen <sam...@openvpn.net> Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 339164f..9511317 100644 --- a/configure.ac +++ b/configure.

Re: [Openvpn-devel] PolarSSL 1.1.0 support?

2012-06-07 Thread Alon Bar-Lev
On Thu, Jun 7, 2012 at 12:24 PM, Samuli Seppänen wrote: > Hi, > > I noticed that my Ubuntu 10.04 and 12.04 buildslaves which had PolarSSL > 1.1.0 failed build during the configure phase: > > checking polarssl version... configure: error: invalid polarssl version > > Updating

Re: [Openvpn-devel] [PATCH 6/8] Allow routes to be set before opening tun, similar to ifconfig before opening tun

2012-06-03 Thread Alon Bar-Lev
Gert, You can see the tun branch[1]. I changed this per platform. Alon. [1] https://github.com/alonbl/openvpn/commits/tun [2] https://github.com/alonbl/openvpn/commit/4d2fc1f21e6c5cba163ec481119370235c736672 On Sun, Jun 3, 2012 at 1:11 PM, Gert Doering wrote: > Hi, > > On

Re: [Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-03 Thread Alon Bar-Lev
On Sun, Jun 3, 2012 at 1:19 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sat, Jun 02, 2012 at 06:30:15PM +0300, Alon Bar-Lev wrote: >> Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com>

Re: [Openvpn-devel] [easy-rsa] New official git repository

2012-06-02 Thread Alon Bar-Lev
Well, You removed all my work. I guess you do this your-self now. On Fri, Jun 1, 2012 at 4:14 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Hi all, > > On behalf of the OpenVPN community developers, I have the pleasure to >

Re: [Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-02 Thread Alon Bar-Lev
On Sat, Jun 2, 2012 at 6:30 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> This time with sign-off.

[Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-02 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- INSTALL | 144 +-- 1 files changed, 85 insertions(+), 59 deletions(-) diff --git a/INSTALL b/INSTALL index ab0d671..209cfa6 100644 --- a/INSTALL +++ b/INSTALL @@ -60,13

Re: [Openvpn-devel] Build broken on Mac OS X

2012-06-02 Thread Alon Bar-Lev
Temporary workaround: have_tap_header="yes" ./configure ... On Sat, Jun 2, 2012 at 6:03 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > On Sat, Jun 2, 2012 at 5:28 PM, Arne Schwabe <a...@rfc2549.org> wrote: >> Am 02.06.12 16:19, schrieb Alon Bar-Lev: >>>

Re: [Openvpn-devel] Build broken on Mac OS X

2012-06-02 Thread Alon Bar-Lev
On Sat, Jun 2, 2012 at 5:28 PM, Arne Schwabe <a...@rfc2549.org> wrote: > Am 02.06.12 16:19, schrieb Alon Bar-Lev: >> Hello, >> >> On Sat, Jun 2, 2012 at 5:14 PM, Arne Schwabe <a...@rfc2549.org> wrote: >>> Hello, >>> >>> while

[Openvpn-devel] [PATCH] build: update INSTALL to recent changes

2012-06-02 Thread Alon Bar-Lev
--- INSTALL | 144 +-- 1 files changed, 85 insertions(+), 59 deletions(-) diff --git a/INSTALL b/INSTALL index ab0d671..209cfa6 100644 --- a/INSTALL +++ b/INSTALL @@ -60,13 +60,12 @@ OPTIONAL (but recommended): (2) LZO real-time

Re: [Openvpn-devel] Build broken on Mac OS X

2012-06-02 Thread Alon Bar-Lev
On Sat, Jun 2, 2012 at 5:28 PM, Arne Schwabe wrote: >>> In the INSTALL file  --with-lzo-headers and --with-lzo-lib is mentioned, >>> which do not work: >>> >> >> >>> LZO_CFLAGS="-I/opt/local/include" LZO_LIBS=-L/opt/local/lib ./configure >> This should have been: >>

Re: [Openvpn-devel] Build broken on Mac OS X

2012-06-02 Thread Alon Bar-Lev
Hello, On Sat, Jun 2, 2012 at 5:14 PM, Arne Schwabe wrote: > Hello, > > while preparing my patches for OS X I also noticed that the build is > broken on OS X: > > [...] > checking net/if_tun.h usability... no > checking net/if_tun.h presence... no > checking for net/if_tun.h...

[Openvpn-devel] [PATCH] build: t_client re-addition

2012-05-28 Thread Alon Bar-Lev
Adding integration tests that needs and/or manual intervention to make check is not something that should be encouraged. Tiered of arguing. But if you add this, at least use the following. --- tests/Makefile.am| 11 ++- tests/t_client.sh.in | 13 - 2 files changed,

Re: [Openvpn-devel] build revolution lost t_client test?

2012-05-27 Thread Alon Bar-Lev
t_client.sh requires root/sudo privileges. "make check" should not assume any special privilege. Because of this it is removed from "make check". You can still run this by hand or we can add special target such as "make root-check" or similar. On Sun, May 27, 2012 at 11:27 PM, Gert Doering

Re: [Openvpn-devel] Pre-2.3-alpha2 Windows installers now available

2012-05-16 Thread Alon Bar-Lev
Hello All, I want to emphasis the request to test as: 1. The installer was fully re-written almost nothing remained from the original one. 2. We now provide both 32bit and 64bit binaries, so far only 32bit binaries were provided. 3. All userspace binaries are compiled using mingw-w64 compiler,

Re: [Openvpn-devel] eurephia plugin

2012-05-16 Thread Alon Bar-Lev
On Wed, May 16, 2012 at 5:30 PM, David Sommerseth wrote: >> But now that you describe you can do this using the plugin API, >> why not modify the plugin to perform this and just remove this? > > I don't know if I'm the only user of this information or not.  If I'm >

Re: [Openvpn-devel] eurephia plugin

2012-05-16 Thread Alon Bar-Lev
On Wed, May 16, 2012 at 3:33 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 16/05/12 14:03, Alon Bar-Lev wrote: > [...snip...] >> But if I get this right, a new configuration option is needed, no

Re: [Openvpn-devel] eurephia plugin

2012-05-16 Thread Alon Bar-Lev
On Wed, May 16, 2012 at 2:37 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 16/05/12 12:55, Alon Bar-Lev wrote: >> On Wed, May 16, 2012 at 1:46 PM, David Sommerseth >> <openvpn.l...@topphemmelig.

Re: [Openvpn-devel] eurephia plugin

2012-05-16 Thread Alon Bar-Lev
On Wed, May 16, 2012 at 1:46 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 16/05/12 12:37, Alon Bar-Lev wrote: >> On Wed, May 16, 2012 at 1:27 PM, David Sommerseth >> <openvpn.l...@topphemmel

Re: [Openvpn-devel] eurephia plugin

2012-05-16 Thread Alon Bar-Lev
On Wed, May 16, 2012 at 1:27 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 16/05/12 09:17, Alon Bar-Lev wrote: > > Hello David, > > > > I guess this is yours: --- *  Additions for eurep

[Openvpn-devel] eurephia plugin

2012-05-16 Thread Alon Bar-Lev
Hello David, I guess this is yours: --- * Additions for eurephia plugin done by: * David Sommerseth Copyright (C) 2009 --- Looking at the code the eurephia plugin only do the following: --- #ifdef ENABLE_PLUGIN_EUREPHIA /* export X509 cert SHA1

[Openvpn-devel] [PATCH] cleanup: update .gitignore

2012-05-15 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 9f546a3..f762089 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,5 @@ *.[oa] +*.l[oa] *.dll *.exe *.exe.* @@

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-15 Thread Alon Bar-Lev
On Tue, May 15, 2012 at 10:34 AM, Seth Mos <seth@dds.nl> wrote: > Op 13-5-2012 20:23, Alon Bar-Lev schreef: >> On Sun, May 13, 2012 at 9:10 PM, Gert Doering<g...@greenie.muc.de>  wrote: > >> Come on! most of installations are plain public key w

Re: [Openvpn-devel] [PATCH] build: integrate plugins build into core build

2012-05-14 Thread Alon Bar-Lev
On Tue, May 15, 2012 at 1:42 AM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > As disucssed[1], keep plugins in repository. > > 1, Proper automake/libtool build. > > 2. Move example plugins to samples/sample-plugins. > > 3. Plugins are installed at LIBDIR/op

[Openvpn-devel] [PATCH] build: integrate plugins build into core build

2012-05-14 Thread Alon Bar-Lev
As disucssed[1], keep plugins in repository. 1, Proper automake/libtool build. 2. Move example plugins to samples/sample-plugins. 3. Plugins are installed at LIBDIR/openvpn/plugins. [1] http://comments.gmane.org/gmane.network.openvpn.devel/6436 Signed-off-by: Alon Bar-Lev <alon.

[Openvpn-devel] [PATCH 2/2] build: spec: we support openssl >= 0.9.7

2012-05-14 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- distro/rpm/openvpn.spec.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/distro/rpm/openvpn.spec.in b/distro/rpm/openvpn.spec.in index de46f59..3c316bf 100644 --- a/distro/rpm/openvpn.spec.in +++ b/dist

[Openvpn-devel] [PATCH 1/2] cleanup: spec: make space/tab consistent

2012-05-14 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- distro/rpm/openvpn.spec.in | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/distro/rpm/openvpn.spec.in b/distro/rpm/openvpn.spec.in index a6f31bd..de46f59 100644 --- a/dist

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories - Discussion Summary

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 9:11 PM, David Sommerseth wrote: > So, please!  Can we rather spend our precious time and energy to fix > *real* bugs?   I would like to spend time in completing the order of build/packaging,

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 9:10 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, May 13, 2012 at 04:10:54PM +0300, Alon Bar-Lev wrote: >> >> And always have pam dependency for this example? >> > >> > FreeBSD, NetBSD, all Linuxes a

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 4:07 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, May 13, 2012 at 03:24:59PM +0300, Alon Bar-Lev wrote: >> > If we ignore the examples, we really only have "auth-pam" and "down-root" >> > in the main d

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 3:19 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, May 13, 2012 at 02:26:05PM +0300, Alon Bar-Lev wrote: >> OK... now you are talking... so you say that like apache we need to >> integrate the plugins to main build system, this w

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
Seth > pfSense developer > > Op 13 mei 2012, om 13:12 heeft Gert Doering het volgende geschreven: > >> Hi, >> >> On Sun, May 13, 2012 at 02:00:32PM +0300, Alon Bar-Lev wrote: >>>>> Can't we progress? >>>> >>>> Why is that pr

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 2:12 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, May 13, 2012 at 02:00:32PM +0300, Alon Bar-Lev wrote: >> >> Can't we progress? >> > >> > Why is that progress? >> > >> > Change always has dra

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 12:35 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, May 13, 2012 at 12:30:37PM +0300, Alon Bar-Lev wrote: >> An healthy community dealing with openvpn need to gather all resources >> that are acting at that niche. >>

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 12:23 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, May 13, 2012 at 12:10:48PM +0300, Alon Bar-Lev wrote: >> And, if not split, they these two plugins should integrated within >> build system. > > This is certainly

Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

2012-05-13 Thread Alon Bar-Lev
On Sun, May 13, 2012 at 12:01 PM, Gert Doering wrote: > Try to build Xorg or teTeX yourself, from packages, and learn from it. We are not xorg... [yet]. Anyway, I think the modular xorg and kde processes are a great success. It allowed them to delegate maintenance, and

Re: [Openvpn-devel] [V2.4 4/4] cleanup: tun: tun_engine interface

2012-05-12 Thread Alon Bar-Lev
On Sat, May 12, 2012 at 10:31 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > Platform independent interface for tun provider. > > Split the long tun.c into platform specific files using > tun_engine interface. > > There is more to be done in order to clean up the code,

[Openvpn-devel] [V2.4 3/4] cleanup: remove tun_adjust_frame_parameters

2012-05-12 Thread Alon Bar-Lev
It is a wrapper of frame_add_to_extra_tun, no sense to keep both around. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/init.c |2 +- src/openvpn/tun.h |6 -- 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/

[Openvpn-devel] [V2.4 2/4] cleanup: move warn_on_use_of_common_subnets to init.c

2012-05-12 Thread Alon Bar-Lev
No dependencies and init.c is the only user. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/init.c | 18 ++ src/openvpn/tun.c | 17 - src/openvpn/tun.h |2 -- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git

[Openvpn-devel] [V2.4 1/4] cleanup: remove check_subnet_conflict

2012-05-12 Thread Alon Bar-Lev
Commeted out as "too many false positives". Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/route.c |1 - src/openvpn/tun.c | 43 --- src/openvpn/tun.h |4 3 files changed, 0 insertions(+), 48 deletion

[Openvpn-devel] [V2.4 0/4] tun cleanups

2012-05-12 Thread Alon Bar-Lev
won't need to rebase. Special thanks to Eric Crist for his FreeBSD help. [1] https://github.com/alonbl/openvpn/compare/build...syshead [2] https://github.com/alonbl/openvpn/compare/syshead...tun Alon Bar-Lev (4): cleanup: remove check_subnet_conflict cleanup: move warn_on_use_of_common_subnets

[Openvpn-devel] [PATCH 16/16] clenaup: syshead: reworder/cleanup includes

2012-05-12 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac |2 +- src/openvpn/syshead.h | 146 - 2 files changed, 36 insertions(+), 112 deletions(-) diff --git a/configure.ac b/configure.ac index cca9508..97eb5f0

[Openvpn-devel] [PATCH 14/16] cleanup: syshead: move SOL_IP emulation to autoconf

2012-05-12 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac | 11 +++ src/openvpn/syshead.h |8 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 2c80ef4..193d287 100644 --- a/configure.ac +++ b/config

[Openvpn-devel] [PATCH 13/16] cleanup: syshead: remove dead code

2012-05-12 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/syshead.h | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index 657c884..f908752 100644 --- a/src/openvpn/syshead.h +++ b/src/openvpn/sys

[Openvpn-devel] [PATCH 12/16] cleanup: syshead: move socket compat into basic.h

2012-05-12 Thread Alon Bar-Lev
Probably not the best place, however, better than syshead. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/basic.h | 17 + src/openvpn/syshead.h | 17 - 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/openvpn/b

[Openvpn-devel] [PATCH 11/16] cleanup: syshead: move _P1003_1B_VISIBLE to autoconf

2012-05-12 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- configure.ac |2 +- src/openvpn/syshead.h |3 --- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 078e46f..2c80ef4 100644 --- a/configure.ac +++ b/configure.ac @@

[Openvpn-devel] [PATCH 06/16] clenaup: syshead: remove wait macros wrappers

2012-05-12 Thread Alon Bar-Lev
WEXITSTATUS is POSIX, show me the platform that does not support this. WIFEXITED is not used at Windows code. Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/syshead.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/src/openvpn/syshe

[Openvpn-devel] [PATCH 09/16] cleanup: syshead: rename S_ERROR->S_ERRORS to avoid conflict with stropts.h

2012-05-12 Thread Alon Bar-Lev
Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> --- src/openvpn/ssl.c| 16 src/openvpn/ssl_common.h |2 +- src/openvpn/syshead.h|1 - 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 1

[Openvpn-devel] [PATCH 08/16] cleanup: syshead: move sleep, random, syshead.h emulation to compat

2012-05-12 Thread Alon Bar-Lev
--- src/compat/compat.h |6 ++ src/openvpn/syshead.h |3 --- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compat/compat.h b/src/compat/compat.h index 021573e..7d91277 100644 --- a/src/compat/compat.h +++ b/src/compat/compat.h @@ -41,6 +41,12 @@ #include

  1   2   3   4   5   6   7   8   >