Re: [Openvpn-devel] [Patch] Wipe Socks5 credentials after use

2021-03-19 Thread Maximilian Fillinger via Openvpn-devel
credentials after use Hi, On Fri, Mar 19, 2021 at 04:45:18PM +, Maximilian Fillinger via Openvpn-devel wrote: [..] The patch itself is OK (I think), but actually applying it will mess up the Author: information in git, because you are sending from a domain that has DMARC p=reject. So mailman

[Openvpn-devel] [Patch] Wipe Socks5 credentials after use

2021-03-19 Thread Maximilian Fillinger via Openvpn-devel
Socks5 plaintext authentication is not exactly high security, but we might as well memzero the credentials before leaving the function. --- src/openvpn/socks.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c

[Openvpn-devel] [PATCH] reliable: retransmit if 3 follow-up ACKs are received

2021-03-18 Thread Maximilian Fillinger via Openvpn-devel
Hi! I'm currently preparing the OpenVPN-NL 2.5 release at Fox-IT. (We're a bit behind the times...) I thought that one of our patches, by Steffan Karger, could be useful in regular OpenVPN. He said that he hadn't submitted it yet, and thought it would be a good idea to ask. The patch increases