Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-12 Thread Juliusz Sosinowicz
Hi Gert, that is the direction I went with the latest patch I sent over. Sincerely Juliusz Sosinowicz On 12/02/2024 13:53, Gert Doering wrote: Hi, On Mon, Feb 12, 2024 at 10:57:41AM +0100, Juliusz Sosinowicz wrote: commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of ACK_SIZE

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-12 Thread Gert Doering
Hi, On Mon, Feb 12, 2024 at 10:57:41AM +0100, Juliusz Sosinowicz wrote: > commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of > ACK_SIZE and RELIABLE_ACK_SIZE in test_ssl.c. These are defined in > reliable.h which should be included through your ssl.h. Since our ssl.h is > being p

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-12 Thread Juliusz Sosinowicz
Hi Arne, commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of ACK_SIZE and RELIABLE_ACK_SIZE in test_ssl.c. These are defined in reliable.h which should be included through your ssl.h. Since our ssl.h is being picked up, these never get defined and make check results in the fo

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-12 Thread Juliusz Sosinowicz
Hi Frank, thank you for the explanation. I did not test out-of-tree builds before submitting the patch. I'll try to implement Gert's solution and write a Makefile patch instead. Sincerely Juliusz Sosinowicz On 09/02/2024 17:39, Frank Lichtenheld wrote: On Fri, Feb 09, 2024 at 04:51:09PM +01

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-09 Thread Arne Schwabe
Am 09.02.24 um 16:51 schrieb Juliusz Sosinowicz: Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The include/wolfssl directory is included before openvpn/src. include/wolfssl needs to be included so that openvpn can pick up wolfSSL compatibility headers instead of OpenSSL heade

[Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-09 Thread Juliusz Sosinowicz
Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The include/wolfssl directory is included before openvpn/src. include/wolfssl needs to be included so that openvpn can pick up wolfSSL compatibility headers instead of OpenSSL headers without changing the paths. --- src/openvpn/aut

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-09 Thread Frank Lichtenheld
On Fri, Feb 09, 2024 at 04:51:09PM +0100, Juliusz Sosinowicz wrote: > Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The > include/wolfssl directory is included before openvpn/src. include/wolfssl > needs to be included so that openvpn can pick up wolfSSL compatibility > headers

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-09 Thread Gert Doering
Hi, On Fri, Feb 09, 2024 at 04:51:09PM +0100, Juliusz Sosinowicz wrote: > Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The > include/wolfssl directory is included before openvpn/src. include/wolfssl > needs to be included so that openvpn can pick up wolfSSL compatibility > he

[Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-09 Thread Juliusz Sosinowicz
Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The include/wolfssl directory is included before openvpn/src. include/wolfssl needs to be included so that openvpn can pick up wolfSSL compatibility headers instead of OpenSSL headers without changing the paths. Signed-off-by: Juli