Re: [Openvpn-devel] [PATCH 1/5] Move memcmp_constant_time() to crypto.h

2016-10-14 Thread Gert Doering
Hi, On Fri, Oct 14, 2016 at 09:54:00AM +0200, Steffan Karger wrote: > > +/** > > + * As memcmp(), but constant-time. > > + * Returns 0 when data is equal, non-zero otherwise. > > + */ > > +static int > > I think this should carry an 'inline', now that it's in the header. Indeed. Do not put non-

Re: [Openvpn-devel] [PATCH 1/5] Move memcmp_constant_time() to crypto.h

2016-10-14 Thread Steffan Karger
Hi David, On 13-10-16 21:59, David Sommerseth wrote: > This function is quite useful other places, so make it generally > accessible. > > Signed-off-by: David Sommerseth > --- > src/openvpn/crypto.c | 18 -- > src/openvpn/crypto.h | 18 ++ > 2 files changed, 18 i

[Openvpn-devel] [PATCH 1/5] Move memcmp_constant_time() to crypto.h

2016-10-13 Thread David Sommerseth
This function is quite useful other places, so make it generally accessible. Signed-off-by: David Sommerseth --- src/openvpn/crypto.c | 18 -- src/openvpn/crypto.h | 18 ++ 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/openvpn/crypto.c b/src