Re: [Openvpn-devel] [PATCH 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

2020-03-14 Thread Gert Doering
Hi, On Fri, Mar 13, 2020 at 02:47:39AM +, Simon Rozman wrote: > True. I'm sure I got this in the original commit back then. Found it... When > rebasing onto the current master, it conflicted and I dropped that change > rather than fixing it. Wrong choice, sorry. Am I reading this

Re: [Openvpn-devel] [PATCH 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

2020-03-12 Thread Simon Rozman
Hi, > A few questions: > > > This also fixes an issue with --windows-driver wintun overriding > > --ip-win32 manual, the later being perfectly fine choice for Wintun > too. > > We do still have code which forces netsh for wintun: > > if (options->windows_driver == WINDOWS_DRIVER_WINTUN)

Re: [Openvpn-devel] [PATCH 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

2020-03-12 Thread Lev Stipakov
Hi, Looks good, tested with interactive service and without (netsh, ipapi). A few questions: > This also fixes an issue with --windows-driver wintun overriding > --ip-win32 manual, the later being perfectly fine choice for Wintun too. We do still have code which forces netsh for wintun:

[Openvpn-devel] [PATCH 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

2020-03-10 Thread Simon Rozman
When provisioning IP configuration, we shall not ask what kind of adapter this is. Rather, we should ask what method of provisioning we are configured to use. It is options.c's job to rule out invalid combinations. - do_ifconfig_ipv4(): unify the workflow with its IPv6 counterpart No need to