Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-04 Thread Gert Doering
Hi, On Sat, Feb 04, 2023 at 02:22:30PM +0100, Arne Schwabe wrote: > Even though I think that adding Cmake as > unsupported build method is a good idea. This would allow others to have > the same option/advantages like me that prefer cmake to > autoconf/automake, this also does not seem to have

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-04 Thread Arne Schwabe
Thanks a lot for that. By adding win32-util.c and -lws2_32 where required, I can now build almost all tests using the autotools framework --- cmocka had to be cross-compiled using cmake which is a pain. I do not particularly like cmake though it'sĀ convenient for Windows MSVC build, so sticki

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-03 Thread Selva Nair
On Fri, Feb 3, 2023 at 5:25 AM Arne Schwabe wrote: > > > Well, replying to myself: > > > > I tried building the unit tests using cmocka for Windows > > (cross-compiling using mingw-w64 with locally built cmocka). > > Unfortunately, none of the tests could be built out of the box because > > of mi

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-03 Thread Arne Schwabe
Well, replying to myself: I tried building the unit tests using cmocka for Windows (cross-compiling using mingw-w64 with locally built cmocka). Unfortunately, none of the tests could be built out of the box because of missing dependencies, so I guess no one is running these tests on Window

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-02 Thread Selva Nair
Hi > > On Wed, Feb 1, 2023 at 6:56 AM Frank Lichtenheld > wrote: > >> On Sat, Jan 28, 2023 at 05:34:21PM -0500, selva.n...@gmail.com wrote: >> > From: Selva Nair >> > >> > Signed-off-by: Selva Nair >> > --- >> > src/openvpn/cryptoapi.c | 44 +++-- >> > 1 fil

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-01 Thread Selva Nair
Hi, On Wed, Feb 1, 2023 at 6:56 AM Frank Lichtenheld wrote: > On Sat, Jan 28, 2023 at 05:34:21PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > Signed-off-by: Selva Nair > > --- > > src/openvpn/cryptoapi.c | 44 +++-- > > 1 file changed, 12

Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-02-01 Thread Frank Lichtenheld
On Sat, Jan 28, 2023 at 05:34:21PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > Signed-off-by: Selva Nair > --- > src/openvpn/cryptoapi.c | 44 +++-- > 1 file changed, 12 insertions(+), 32 deletions(-) > > diff --git a/src/openvpn/cryptoapi.c b/

[Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string

2023-01-28 Thread selva . nair
From: Selva Nair Signed-off-by: Selva Nair --- src/openvpn/cryptoapi.c | 44 +++-- 1 file changed, 12 insertions(+), 32 deletions(-) diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c index 6ff4fcb5..9fd5aea9 100644 --- a/src/openvpn/cryptoapi.c