On Sun, Jan 22, 2017 at 05:31:56PM +0100, Steffan Karger wrote:
> Hi,
>
> One more real comment and two nitpicks:
>
> On 15-01-17 15:43, Antonio Quartulli wrote:
> > @@ -3233,39 +3258,63 @@ options_postprocess_filechecks(struct options
> > *options)
> >
> > [...]
> >
> > +errs |= check_file_
Hi,
One more real comment and two nitpicks:
On 15-01-17 15:43, Antonio Quartulli wrote:
> @@ -3233,39 +3258,63 @@ options_postprocess_filechecks(struct options
> *options)
>
> [...]
>
> +errs |= check_file_access_inline(options->cert_file_inline, CHKACC_FILE,
> +
Carrying around the INLINE_TAG is not really efficient,
because it requires a strcmp() to be performed every
time we want to understand if the data is stored inline
or not.
Convert all the *_inline attributes to bool to make the
logic easier and checks more efficient.
Signed-off-by: Antonio Quart
