Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/525?usp=email )
Change subject: Minor fix to process_ip_header
..
Hi,
On Mon, Feb 19, 2024 at 02:23:08PM +0100, Antonio Quartulli wrote:
> On 19/02/2024 14:12, Gert Doering wrote:
> > Maybe that would be a more reasonable approach here... get rid of the
> > umbrella if(), and check individual bits inside. It seems to be a
> > micro-optimization "skip this
Hi,
On 19/02/2024 14:12, Gert Doering wrote:
Maybe that would be a more reasonable approach here... get rid of the
umbrella if(), and check individual bits inside. It seems to be a
micro-optimization "skip this branch if we have no single feature active",
while at least MSSFIX is active by
Hi,
On Mon, Feb 19, 2024 at 02:08:56PM +0100, Antonio Quartulli wrote:
> This said, I do believe this patch fixes these issues in one go as the new
> PIP_OPT_MASK will match all the flags mentioned above.
Yes, but then we do not need that if() anymore at all - if we go in
there, no matter if we
Hi,
On 16/02/2024 15:00, Antonio Quartulli wrote:
Hi,
On 15/02/2024 17:17, Gert Doering wrote:
Hi,
On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote:
if (buf->len > 0)
{
- /*
- * The --passtos and --mssfix options require
- * us to
Hi,
On 15/02/2024 17:17, Gert Doering wrote:
Hi,
On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote:
if (buf->len > 0)
{
-/*
- * The --passtos and --mssfix options require
- * us to examine the IPv4 header.
- */
-
-if
Hi,
Il 15/02/2024 17:17, Gert Doering ha scritto:
Hi,
On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote:
if (buf->len > 0)
{
-/*
- * The --passtos and --mssfix options require
- * us to examine the IPv4 header.
- */
-
-
Hi,
On Thu, Feb 15, 2024 at 03:59:02PM +, its_Giaan (Code Review) wrote:
> if (buf->len > 0)
> {
> -/*
> - * The --passtos and --mssfix options require
> - * us to examine the IPv4 header.
> - */
> -
> -if (flags & (PIP_MSSFIX
> -#if
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/525?usp=email
to review the following change.
Change subject: Minor fix to process_ip_header
