Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2021-02-01 Thread Gert Doering
Hi, On Thu, Feb 13, 2020 at 03:53:04PM +0100, Arne Schwabe wrote: > This on of the old patches that are still pending. It seems that the > original submitter never replied. This is still something we want to > merge or should we just "close" due to timeout? I am not too familiar > with the DHCP

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2020-02-13 Thread Arne Schwabe
Am 14.03.18 um 17:17 schrieb Selva Nair: > Hi, > > On Wed, Mar 14, 2018 at 3:32 AM, Jiří Engelthaler wrote: >> Hi. >> You right. Disabled dhcp media sense can be set as global for all >> interfaces or in adapter specific setting if it supports it (TAP supports >> it). >> But for must users is

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-03-14 Thread Selva Nair
Hi, On Wed, Mar 14, 2018 at 3:32 AM, Jiří Engelthaler wrote: > Hi. > You right. Disabled dhcp media sense can be set as global for all > interfaces or in adapter specific setting if it supports it (TAP supports > it). > But for must users is the global settings hidden deep in

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-03-14 Thread Jiří Engelthaler
Hi. You right. Disabled dhcp media sense can be set as global for all interfaces or in adapter specific setting if it supports it (TAP supports it). But for must users is the global settings hidden deep in the system and for me it took several months to find the cause of my problems. Interface

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-03-13 Thread Selva Nair
Hi, On Tue, Mar 13, 2018 at 7:36 AM, Jiří Engelthaler wrote: > > Any discussion / opinions ? Here > https://github.com/OpenVPN/openvpn/pull/97#issuecomment-372530059 > one user reported, that this patch were useful for him. Though I agree that checking for whether media sense

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-03-13 Thread Jiří Engelthaler
Any discussion / opinions ? Here https://github.com/OpenVPN/openvpn /pull/97#issuecomment-372530059 one user reported, that this patch were useful for him. 2018-01-31 14:37 GMT+01:00 Jiří Engelthaler : > Comments accepted. Thank you Selva. This patch is also as pull request >

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-01-31 Thread Jiří Engelthaler
Comments accepted. Thank you Selva. This patch is also as pull request https://github.com/OpenVPN/openvpn/pull/97 When DHCP media sense configuration is disabled, network applications including DHCP client will not receive information about link status changes and the link seems to be always

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-01-21 Thread Selva Nair
Hi, I haven't tested this, but looks like a useful thing to do. The code looks good too. Some minor comments below: On Tue, Dec 5, 2017 at 7:19 AM, Jiří Engelthaler wrote: > When DHCP media sense configuration is disabled, network applications > including DHCP client will not

Re: [Openvpn-devel] [PATCH] Add a warning for disabled DHCP media sense on Window

2018-01-11 Thread Jiří Engelthaler
Any comments on this my patch? https://sourceforge.net/p/openvpn/mailman/message/36146985/ https://github.com/OpenVPN/openvpn/pull/97 Jiří Engelthaler -- Check out the vibrant tech community on one of the world's most