[Openvpn-devel] [PATCH] Fix --multihome for IPv6 on 64bit BSD systems.

2016-10-09 Thread Gert Doering
The old code only worked if "struct openvpn*pktinfo" happened to use the same structure packing as the CMSG_SPACE() / CMSG_LEN() macros (which are part of the official API, see RFC 2292). Get rid of "struct openvpn_*_pktinfo" definitions, replace them by an opaque buffer sized large enough to fit

Re: [Openvpn-devel] [PATCH] Fix --multihome for IPv6 on 64bit BSD systems.

2016-10-09 Thread Arne Schwabe
Am 09.10.16 um 12:09 schrieb Gert Doering: > The old code only worked if "struct openvpn*pktinfo" happened to use > the same structure packing as the CMSG_SPACE() / CMSG_LEN() macros > (which are part of the official API, see RFC 2292). > > Get rid of "struct openvpn_*_pktinfo" definitions, replac

Re: [Openvpn-devel] [PATCH applied] Fix --multihome for IPv6 on 64bit BSD systems.

2016-10-09 Thread Gert Doering
Thanks, Arne. Patch has been applied to the following branches commit 3fb246e38fc670c7dfff8ce4521c75c95c766c9e (master) commit f7aba873ca593eb2ab8a4a358cd6c06ef46a09e1 (release/2.3) Author: Gert Doering Date: Sun Oct 9 12:09:29 2016 +0200 Fix --multihome for IPv6 on 64bit BSD systems.

[Openvpn-devel] strtok on Windows

2016-10-09 Thread Selva Nair
Hi, As per MSDN, strtok on Windows is thread-safe --- uses thread-local static for the internal state (though not reentrant). Anyone knows whether this is true even when mingw is used --- does it use strtok from Microsoft's run time or some internal implementation? I have patch for the GUI that u

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-09 Thread Gert Doering
Hi, On Fri, Jun 24, 2016 at 06:01:41PM +0200, Heiko Hund wrote: > This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some > initialization code to init_tun, where it belongs, and removes duplicate > code that is now no longer needed. Plus "it tries to make code look nicer and breaks i

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-09 Thread Gert Doering
Hi, On Sun, Oct 09, 2016 at 05:06:59PM +0200, Gert Doering wrote: > Running more tests with that hunk reverted next... With the following patch applied on top of Heiko's patch diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 4a11d10..1250547 100644 --- a/src/openvpn/tun.c +++ b/src/openv

Re: [Openvpn-devel] strtok on Windows

2016-10-09 Thread Selva Nair
On Sun, Oct 9, 2016 at 11:02 AM, Selva Nair wrote: > As per MSDN, strtok on Windows is thread-safe --- uses thread-local > static for the internal state (though not reentrant). Anyone knows > whether this is true even when mingw is used --- does it use strtok from > Microsoft's run time or some i

[Openvpn-devel] [PATCH v2] Use separate list for per-client push options

2016-10-09 Thread Lev Stipakov
v2: - Also move ifconfig and ipv6-ifconfig to separate options list Move client-specific push options (currently peer-id and cipher) to separate list, which is deallocated after push_reply has been send. This makes sure that options fit into buf, not duplicated nor leak memory on renegotiation.