Re: [Openvpn-devel] [PATCH v2 1/3] Move dco_installed from sock->info to sock->info.lsa.actual

2022-12-05 Thread Gert Doering
Hi, On Tue, Nov 01, 2022 at 11:21:40AM +0200, Lev Stipakov wrote: > > @@ -1190,7 +1190,7 @@ link_socket_write(struct link_socket *sock, > >struct buffer *buf, > >struct link_socket_actual *to) > > { > > -if (proto_is_udp(sock->info.proto) || sock->info.

Re: [Openvpn-devel] [PATCH] implement net_gateway_ipv6 for --route-ipv6

2022-12-05 Thread Gert Doering
Hi, On Mon, Sep 19, 2022 at 09:13:10PM +0200, Antonio Quartulli wrote: > For the records, the following changes were requested to this patch > (some via GH): > > 1) improve (add?) commit message; > 2) add comments/documentation to ipv6_get_special_addr() > 3) get rid of the ipv6_is_special_addr(

[Openvpn-devel] OpenVPN 2.6_beta1 released

2022-12-05 Thread Frank Lichtenheld
The OpenVPN community project team is proud to release OpenVPN 2.6_beta1. This is the first Beta release for the feature release 2.6.0. Some highlights of this release are: * Data Channel Offload (DCO) kernel acceleration support for Windows, Linux, and FreeBSD. * OpenSSL 3 support. * Improved h

[Openvpn-devel] [PATCH 2/4] dco: Update counters when a client disconnects

2022-12-05 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost When the kernel module (Linux or FreeBSD) notifies us that a peer has disconnected we'd like to get a final count of the in/out bytes for that peer. We can't request that information any more, because the kernel has already removed the peer at that point. Have the kernel se

[Openvpn-devel] [PATCH]: FreeBSD DCO updates

2022-12-05 Thread Kristof Provost via Openvpn-devel
Hi, This patch series is version two of the "Read DCO traffic stats from the kernel" patch. This version should build for FreeBSD, Linux and Windows now (although I've not tested Windows builds, because I lack Windows machines). It also adds the ability for DCO drivers to include counters in the

[Openvpn-devel] [PATCH 4/4] dco: cleanup FreeBSD dco_do_read()

2022-12-05 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Remove support for reading packets through the control interface. FreeBSD no longer does this, so there's no point in keeping the code for it. While here also check that we know what type of notification we're getting. There's currently only one, but we should check anyway.

[Openvpn-devel] [PATCH 3/4] Read the peer deletion reason from the kernel

2022-12-05 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Recent FreeBSD kernels supply a reason for the OVPN_NOTIF_DEL_PEER notification. Parse this from the nvlist so we can distinguish user-requested removals from timeouts. Signed-off-by: Kristof Provost --- src/openvpn/dco_freebsd.c | 13 + src/openvpn/ovpn_

[Openvpn-devel] [PATCH 1/4] Read DCO traffic stats from the kernel

2022-12-05 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost When DCO is active userspace doesn't see all of the traffic, so when we access these stats we must update them. Retrieve kernel statistics every time we access the link_(read|write)_bytes values. Introduce a dco_(read|write)_bytes so that we don't clobber the existing stat