Attention is currently required from: flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change by stipa. (
http://gerrit.openvpn.net/c/openvpn/+/903?usp=email )
Change subject: Make recursive routing check more fine-grained
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
Hello cron2, flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/903?usp=email
to look at the new patch set (#4).
The following approvals got outdated an
Stared at code, and tested on Linux. Under "normal operations" (that
is "packets are directed into the tunnel by routing") this does not
make a difference, except logging with source ip+port as well
Old:
2025-10-11 12:52:06 us=938009 Recursive routing detected, drop tun packet to
[AF_INET6]260
cron2 has uploaded a new patch set (#5) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/903?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Make recursive routing check more fine-grained
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/903?usp=email )
Change subject: Make recursive routing check more fine-grained
..
Make recursive routing check more fine-grained
The existing recursive ro
cron2 has uploaded a new patch set (#14) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/474?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: test_user_pass: Check fatal errors for empty username/
This needed a few rounds on my end - the patch adds a new file that
consists of "CR+NL" line endings, and "git am --whitespace=fix"
helpfully fixed that... pushing to GHA still worked(!), seems the
test magic running this on a windows machine restored the line endings
- my own tests on FreeBSD and
From: Frank Lichtenheld
Seems suitably related and tun.c is one of the
huge ones.
In preparation of adding UTs for the code.
Change-Id: I62a8f62b9c0938cfcb99d184b07034515c076303
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1265
---
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1266?usp=email )
Change subject: dhcp: Replace DHCP Option types with defines
..
dhcp: Replace DHCP Option types with defines
Just nicer. Verified against
