Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-06 Thread Antonio Quartulli
On Mon, Feb 06, 2017 at 08:18:01PM +0100, Olivier W wrote: > Should be compatible with all versions of OpenSSL and LibreSSL. > Similar to what is done in curl: > https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355/lib/vtls/openssl.c#L603-L619 > > Error while compiling was:

[Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-06 Thread Olivier W
Should be compatible with all versions of OpenSSL and LibreSSL. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355/lib/vtls/openssl.c#L603-L619 Error while compiling was: "ssl_openssl.c:512:30: error: no member named 'cert' in 'struct

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-06 Thread David Sommerseth
On 06/02/17 12:19, Илья Шипицин wrote: > > it is the same as previous version of this patch, which I sent before > your guidelines, and you did not complain earlier. > it is not clear, how 167 chars long might be bad or good. for me it is > just 167 chars. You do understand and realize you just

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-06 Thread Илья Шипицин
2017-02-06 15:44 GMT+05:00 David Sommerseth : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I have ACKed and applied this, just to get this one resolved. But I am > very > disappointed that you have yet again completely ignored the guidelines > described in the URL[1]

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I have ACKed and applied this, just to get this one resolved. But I am very disappointed that you have yet again completely ignored the guidelines described in the URL[1] already provided to you - which describes how a patch and commit message should