From: Antonio Quartulli
The problem is visible when compiling with -O2:
ntlm.c: In function ‘ntlm_phase_3’:
ntlm.c:305:9: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
if ((*((long *)&buf2[0x14]) & 0x0080) == 0x0080)
The spec s
From: Antonio Quartulli
The problem is visible when compiling with -O2:
ntlm.c: In function ‘ntlm_phase_3’:
ntlm.c:305:9: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
if ((*((long *)&buf2[0x14]) & 0x0080) == 0x0080)
The spec s
Aloha,
On 15/08/17 23:39, Steffan Karger wrote:
> This function is only used in init.c, and is not easy to fit into a
> specific category because it both runs scripts and plugin hooks. Making
> it static in init.c is probably the best place for this function.
>
> (I think we should find a better
On 15/08/17 23:54, David Sommerseth wrote:
> We have quite a list of deprecated options currently. Ensure this
> is highlighted both in documentation and code.
>
> This patch builds on the wiki page [1] enlisting all deprecated features
> and their status. There are also some options not listed
We have quite a list of deprecated options currently. Ensure this
is highlighted both in documentation and code.
This patch builds on the wiki page [1] enlisting all deprecated features
and their status. There are also some options not listed here, as
there exists patches in release/2.4 which aw
A simple clean-up where the version references have been unified
all those places I could find now. The versioning scheme used is:
* OpenVPN 2.x
* v2.x
We want to avoid:
* 2.x (2.4 can be just an ordindary decimal number,
OID reference, a version number or anything else)
On 16/08/17 04:15, Steffan Karger wrote:
> Hi,
>
> On 12-08-17 06:05, Antonio Quartulli wrote:
>> From: Antonio Quartulli
>>
>> The problem is visible when compiling with -O2:
>>
>> ntlm.c: In function ‘ntlm_phase_3’:
>> ntlm.c:305:9: warning: dereferencing type-punned pointer will break
>> st
Hi,
On 12-08-17 06:05, Antonio Quartulli wrote:
> From: Antonio Quartulli
>
> The problem is visible when compiling with -O2:
>
> ntlm.c: In function ‘ntlm_phase_3’:
> ntlm.c:305:9: warning: dereferencing type-punned pointer will break
> strict-aliasing rules [-Wstrict-aliasing]
> if
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
ACK. Please send patch for git master removing this feature. I
considered applying it to git master, as a way to track it. But decided not
to do that now.
Your patch has been applied to the release/2.4 branch.
commit e3da00918d2dd99c116f6da1a14a2
This function is only used in init.c, and is not easy to fit into a
specific category because it both runs scripts and plugin hooks. Making
it static in init.c is probably the best place for this function.
(I think we should find a better place for everything currently in misc.c,
and get rid of i
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
ACK. The patch have been slightly adopted to git master and applied to
release/2.4. In addition, the final deprecation was moved to v2.6.
Your patch has been applied to the following branches
commit ad178f01444d61e48fca83c4f0bc5d82270cee87 (mast
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
ACK. This makes sense and works as expected.
Your patch has been applied to the release/2.3 branch
commit 49e12a39abdecb4c63ea0e577f9abc18e0eda082
Author: Steffan Karger
Date: Tue Aug 8 22:00:47 2017 +0200
Deprecate --ns-cert-type
Tr
Am 15.08.17 um 11:29 schrieb David Sommerseth:
> On 15/08/17 11:17, Илья Шипицин wrote:
> [...]
>> > there are special cases like Mikrotik openvpn (pretty popular), where
>> > user simply use what hardware vendor installed (without possibility to
>> > recompile).
>> >
>> > shoul
On 15/08/17 11:17, Илья Шипицин wrote:
[...]
> > there are special cases like Mikrotik openvpn (pretty popular), where
> > user simply use what hardware vendor installed (without possibility to
> > recompile).
> >
> > should we contact such hardware vendors as well ?
>
> th
2017-08-15 13:32 GMT+05:00 Antonio Quartulli :
>
>
> On 15/08/17 16:26, Илья Шипицин wrote:
> > 2017-08-14 15:36 GMT+05:00 David Sommerseth <
> > open...@sf.lists.topphemmelig.net>:
> >
> >> On 01/07/17 13:29, Steffan Karger wrote:
> >>
> >> So I propose:
> >>
> >> - We add the warning about remov
On 15/08/17 16:26, Илья Шипицин wrote:
> 2017-08-14 15:36 GMT+05:00 David Sommerseth <
> open...@sf.lists.topphemmelig.net>:
>
>> On 01/07/17 13:29, Steffan Karger wrote:
>>
>> So I propose:
>>
>> - We add the warning about removing --keysize for both v2.4 and v2.5.
>>
>> - Add a warning in v2.4
2017-08-14 15:36 GMT+05:00 David Sommerseth <
open...@sf.lists.topphemmelig.net>:
> On 01/07/17 13:29, Steffan Karger wrote:
> > The --keysize option can only be used with already deprecated ciphers,
> > such as CAST5, RC2 or BF. Deviating from the default keysize is
> > generally not a good idea
17 matches
Mail list logo
