[Openvpn-devel] [PATCH applied] Re: reliable: remove reliable_unique_retry()

Acked-by: Gert Doering Note that this change does not actually remove the exponential backoff logic, just some magic extra bits added to it - possibly to avoid server side synchronization if there are lots of clients that all have packet loss. Since ovpn3 has no server side, it's not exactly s

Re: [Openvpn-devel] [PATCH v3] Use lowest metric interface when multiple interfaces match a route

Hi, On Fri, Jan 26, 2018 at 10:26:58AM -0500, Selva Nair wrote: > The mystery (at least for me) is where that host part is coming > from... Its zeroed out before setting the route, and I thought the > same (?) route list pointer is > passed in while deleting routes. So. Staring a bit at the cod

[Openvpn-devel] [PATCH applied] Re: reliable: remove reliable_unique_retry()

Acked-by: Gert Doering Note that this change does not actually remove the exponential backoff logic, just some magic extra bits added to it - possibly to avoid server side synchronization if there are lots of clients that all have packet loss. Since ovpn3 has no server side, it's not exactly s

[Openvpn-devel] [PATCH] travis-ci: add pkcs11-helper patch identical to openvpn-build

currently patch of implementing RFC7512 URI Scheme is added during building windows installer. The same patch was added to travis-ci cross builds Signed-off-by: Ilya Shipitsin --- .travis/build-deps.sh | 17 +- .travis/pkcs11-helper-001-RFC7512.patch | 656

Re: [Openvpn-devel] [PATCH 2/2] Make most registry values optional

Hi, On Tue, Feb 20, 2018 at 11:14 AM, Gert Doering wrote: > Hi, > > well, today is the day that I get to break things, it seems... > > On Sat, Nov 18, 2017 at 12:40:58PM -0500, selva.n...@gmail.com wrote: >> +/* The default value of REG_KEY is the install path */ >> +if (GetRegString(key,

Re: [Openvpn-devel] [PATCH applied] Re: Ensure strings read from registry are null-terminated

Hi, On Tue, Feb 20, 2018 at 09:47:43AM -0500, Selva Nair wrote: > > There was one issue with your patch that you might want to look into - it > > seems to be based on a private branch that has a "#define REG_KEY" which [..] > > That line got removed by the following commit (multiple service insta

[Openvpn-devel] Topics for the community meeting (Wed, 21st Feb 2018)

Hi, We're going to have an IRC meeting starting at 11:30 CET (10:30 UTC) on #openvpn-meeting irc.freenode.net. You do not have to be logged in to Freenode to join the channel. Current topic list along with basic information is here:

[Openvpn-devel] [PATCH applied] Re: travis-ci: modify openssl build script to support openssl-1.1.0

Your patch has been applied to the master and release/2.4 branch. commit 437be780996501becb18f0d34c256ab9c9fe27af (master) commit b7aea67aa11b73417eeff595d13b0e2a7b9c925c (release/2.4) Author: Ilya Shipitsin Date: Mon Jan 15 13:05:55 2018 +0500 travis-ci: modify openssl build script to sup

[Openvpn-devel] [PATCH applied] Re: Use lowest metric interface when multiple interfaces match a route

Acked-by: Gert Doering Based on JJK's test results, staring at the code, understanding the intent :-) and test compilation on 16.04. Your patch has been applied to the master and release/2.4 branch. TODO: figuring out what's wrong with the IPv6 route "host bits", but that's totally outside thes

[Openvpn-devel] [PATCH applied] Re: Make most registry values optional

Acked-by: Gert Doering "Because it makes sense". Stared at the code, compile-tested on 16.04. Same issue as in 1/2 with the "reg_path" change... but again, only conflicts in context, not actual code, and context that is not affected by the code changes. Your patch has been applied to the mas

[Openvpn-devel] [PATCH applied] Re: Ensure strings read from registry are null-terminated

Acked-by: Gert Doering "Because it makes sense" (checked with the Windows API documentation, and compile-tested on ubuntu 16.04). Your patch has been applied to the master and release/2.4 branch. There was one issue with your patch that you might want to look into - it seems to be based on a pr

Re: [Openvpn-devel] [PATCH applied] Re: Allow external EC key through --management-external-key

Hi, On Tue, Feb 20, 2018 at 11:30:35AM +0100, Gert Doering wrote: > Your patch has been applied to the master branch. > > (I have not done any real review on it, except "compile test" and "stare > a bit at the code for really obvious issues" - trusting Arne since his > GUI seems to be the only th

[Openvpn-devel] [PATCH applied] Re: Allow external EC key through --management-external-key

Your patch has been applied to the master branch. (I have not done any real review on it, except "compile test" and "stare a bit at the code for really obvious issues" - trusting Arne since his GUI seems to be the only thing really using it today, so if he's happy, I am as well) commit 7eca140c70

[Openvpn-devel] [PATCH applied] Re: show the right string for key-direction

Your patch has been applied to the master and release/2.4 branch. commit 7f7f00da88eeea847da57f4f34c66c1f4a935a73 (master) commit 6725074ba0af914f85e6dbbef5eff08c2539c5b8 (release/2.4) Author: Arne Schwabe Date: Wed Jan 31 10:53:00 2018 +0100 show the right string for key-direction A

Re: [Openvpn-devel] [PATCH applied] Re: Enable stricter compiler warnings by default

Hi, On Tue, Feb 20, 2018 at 10:41:08AM +0100, Gert Doering wrote: > Your patch has been applied to the master and release/2.4 branch. > > Tested on FreeBSD 10, Linux and, indeed, AIX 7 :-) - Linux/gcc is nicely > clean, FreeBSD/clang finds a few that are silly and want fixing... Yeah. Right. A

[Openvpn-devel] [PATCH applied] Re: Enable stricter compiler warnings by default

Your patch has been applied to the master and release/2.4 branch. Tested on FreeBSD 10, Linux and, indeed, AIX 7 :-) - Linux/gcc is nicely clean, FreeBSD/clang finds a few that are silly and want fixing... ../../../openvpn/src/openvpn/push.c:42:13: warning: unused variable 'push_rep

[Openvpn-devel] [PATCH applied] Re: Log pre-handshake packet drops using D_MULTI_DROPPED

Acked-by: Gert Doering "because the reasoning make sense, and the code change is trivial enough" Your patch has been applied to the master and release/2.4 branch. commit c215c58f2393e881e16f9805549316a1e257a682 (master) commit 38595e9b1f337ee22a94154323eb14408ed86ef8 (release/2.4) Author: Steff

Re: [Openvpn-devel] [PATCH] Fix format spec errors in Windows builds

Hi, On Mon, Feb 19, 2018 at 03:26:34PM -0500, selva.n...@gmail.com wrote: > - In route.c print adapter_index as unsigned int as in the rest > of the code. That one confuses me, but that is most likely me vs. windows types. adapter_index is declared as "DWORD" in tun.h, and https://msdn.mic