Simple and to the point :-) - much more commit message than code change.
Your patch has been applied to the master branch.
commit 96ae327add16f06ac8bc28cfbf9ba0abfcc7129c
Author: Steffan Karger
Date: Tue Jul 7 16:26:21 2020 +0200
Make openvpn --version exit with exit code 0
Your patch has been applied to the master branch.
Commit message amended as ordered by the whitespace dragon.
commit 05ffefcca997708e1f146bed6f5dba9b9f5b1e90
Author: Arne Schwabe
Date: Tue Jul 7 14:16:13 2020 +0200
Simplify multi_connection_established.
Signed-off-by: Arne Schwabe
Hi,
On 07/07/2020 14:16, Arne Schwabe wrote:
> This order the states from unauthenticated to authenticated and also
> changes the comparison for KS_AUTH_FALSE from != to >
>
> Also remove a now obsolete comment and two obsolete ifdefs. While
> keeping the ifdef in ssl_verify would save a few
Hi,
On 06/07/20 18:15, Gert Doering wrote:
Hi,
On Tue, Jun 30, 2020 at 04:15:58PM +0200, Jan Just Keijser wrote:
On 30/06/20 16:11, Gert Doering wrote:
On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote:
@@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf,
Hi,
On 07/07/2020 14:16, Arne Schwabe wrote:
> Instead of having the whole function as
>
> if (x) { func }
>
> do
>
>if (!x) func
I guess this commit message needs some love? You probably meant:
Instead of..
if (x) { func }
do
if (!x) return;
func
At
Hi,
On 07/07/2020 16:26, Steffan Karger wrote:
> For some reason, openvpn --version has since the beginning of time
> returned exit code 1. A quick sample among common unix utilities confirms
> that the rest of the world agrees with me that 0 makes more sense. Let's
> make openvpn --version exit
For some reason, openvpn --version has since the beginning of time
returned exit code 1. A quick sample among common unix utilities confirms
that the rest of the world agrees with me that 0 makes more sense. Let's
make openvpn --version exit with exit code 0 too.
Signed-off-by: Steffan Karger
Am 07.07.20 um 14:16 schrieb Arne Schwabe:
> This allows git blame to ignore reformatting changes and instead
> shows the previous commit that changed the line.
Ignore the first two patches.
git send-email-to=openvpn-devel@lists.sourceforge.net *patch
is a dangerous thing to do. The other
This order the states from unauthenticated to authenticated and also
changes the comparison for KS_AUTH_FALSE from != to >
Also remove a now obsolete comment and two obsolete ifdefs. While
keeping the ifdef in ssl_verify would save a few bytes of code,
this is too minor to justify keeping the
This allows git blame to ignore reformatting changes and instead
shows the previous commit that changed the line.
To avoid manually building the list of commits this commit
adds a file with a list of reformatting commits. I might have
missed a few but this should be a good start. To use the file
Instead of having the whole function as
if (x) { func }
do
if (!x) func
Due to the whitespace changes in the function body this patch looks
very strange. Ignoring whitespace makes the diff look sane.
Signed-off-by: Arne Schwabe
---
src/openvpn/multi.c | 476
This allows git blame to ignore reformatting changes and instead
shows the previous commit that changed the line.
To avoid manually building the list of commits this commit
adds a file with a list of reformatting commits. I might have
missed a few but this should be a good start. To use the file
Ever since the NCPv2 the ncp_get_best_cipher uses the global
options->ncp_enabled option and ignore the tls_session->ncp_enabled
option.
The server side's poor man's NCP is implemented as seeing the list
of supported ciphers from the peer as just one cipher so this special
handling for poor man's
I merged this somewhat by accident, so apologies for the confusion - I am
*not* ignoring Antonio's and Steffan's comments for improvement of this
patch, but I had my trees mixed up from testing, and it got pushed out
with the "writepid" patch of today by accident.
So:
Acked-by: Gert Doering
Hi,
Didn't find time to fully review, but I think this is moving into the
right direction. I did notice something I'd like you to consider:
On 06-07-2020 18:35, Arne Schwabe wrote:
> @@ -2466,7 +2466,7 @@ key_method_2_write(struct buffer *buf, struct
> tls_session *session)
> if
Patch has been applied to the master branch.
Tab has been expanded to pacify the whitespace dragon.
commit 008ec688d06101c0307e6d17a0239b134355dca4
Author: Gert Doering
Date: Tue Jul 7 10:42:20 2020 +0200
Remove --writepid file on program exit.
Signed-off-by: Gert Doering
Hi,
On 07/07/2020 10:42, Gert Doering wrote:
> For whatever reason, we never removed the pid file on program exit.
>
> Not only this is unclean, but it also makes testing for "I want this
> test case to FAIL" in t_client.sh more annoying to code for "is the
> OpenVPN process still around?"...
>
For whatever reason, we never removed the pid file on program exit.
Not only this is unclean, but it also makes testing for "I want this
test case to FAIL" in t_client.sh more annoying to code for "is the
OpenVPN process still around?"...
Do not unlink the file if chroot() is active (might be
18 matches
Mail list logo
