[Openvpn-devel] [PATCH v3] Support x509 field list to be username

2020-08-15 Thread Vladislav Grishenko
OpenVPN has the ability to choose different x509 field in case "CN" can't be use used to be unique connected username since commit 935c62be9c0c8a256112df818bfb8470586a23b6. Unfortunately it's not enough in case client has multiple and valid certificates from PKI for different devices (ex. laptop,

Re: [Openvpn-devel] [PATCH 1/2] Support multiple x509 field list to be username

2020-08-15 Thread Vladislav Grishenko
Hi, >> #ifdef ENABLE_X509ALTUSERNAME >> -to.x509_username_field = (char *) options->x509_username_field; >> +memmove(to.x509_username_field, options->x509_username_field, >> sizeof(to.x509_username_field)); >> #else >> -to.x509_username_field = X509_USERNAME_FIELD_DEFAULT; >> +

Re: [Openvpn-devel] [PATCH 0/2] Fix mistyped option names

2020-08-15 Thread Gert Doering
Hi, On Sat, Aug 15, 2020 at 02:05:20PM +0200, Magnus Kroken wrote: > While preparing a 2.5_beta1 package, I had to look > back and forth betwenn various sources to get option > names right. It seems that in some places names are > altered to make grammatical sense, which I find > confusing.

Re: [Openvpn-devel] 2.5-beta-1 Windows installer problems

2020-08-15 Thread tincanteksup
Comment inline: On 15/08/2020 19:29, tincanteksup wrote: Hi, I would like to document the very strange issues I had testing the 2.5 MSI installers. The first test was on a Win7-Ent/32bit VM with 32bit installer.  The second test was a real PC with Win7-HomePro/64bit (yeah, user did not

[Openvpn-devel] 2.5-beta-1 Windows installer problems

2020-08-15 Thread tincanteksup
Hi, I would like to document the very strange issues I had testing the 2.5 MSI installers. The first test was on a Win7-Ent/32bit VM with 32bit installer. The second test was a real PC with Win7-HomePro/64bit (yeah, user did not want w10) 64bit installer. The third test was Win10/64bit VM

[Openvpn-devel] [PATCH 0/2] Fix mistyped option names

2020-08-15 Thread Magnus Kroken
While preparing a 2.5_beta1 package, I had to look back and forth betwenn various sources to get option names right. It seems that in some places names are altered to make grammatical sense, which I find confusing. "Data cipher" and "compression" are simply words, and it makes sense to use the

[Openvpn-devel] [PATCH 2/2] doc: fix typos in cipher-negotiation.rst

2020-08-15 Thread Magnus Kroken
Signed-off-by: Magnus Kroken --- doc/man-sections/cipher-negotiation.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/man-sections/cipher-negotiation.rst b/doc/man-sections/cipher-negotiation.rst index f1433052..a2feb5f9 100644 ---

[Openvpn-devel] [PATCH 1/2] Changes.rst: fix mistyped option names

2020-08-15 Thread Magnus Kroken
Signed-off-by: Magnus Kroken --- Changes.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Changes.rst b/Changes.rst index 0aee3603..f67e1d76 100644 --- a/Changes.rst +++ b/Changes.rst @@ -34,7 +34,7 @@ Improved Data channel cipher negotiation Removal of BF-CBC