Re: [Openvpn-devel] [PATCH] If IPv6 pool specification sets pool start to ::0 address, increment.

2020-09-16 Thread Antonio Quartulli
Hi, On 11/09/2020 13:59, Gert Doering wrote: > The first IPv6 address in a subnet is not usable (IPv6 anycast address), > but our pool code ignored this. > > Instead of assigning an unusable address or erroring out, just log the > fact, and increment the pool start to ::1 > > NOTE: this is a bit

Re: [Openvpn-devel] [PATCH v2] Fix fatal error at switching remotes (#629)

2020-09-16 Thread Lev Stipakov
Hi, > If remote server has been resolved to multiple addresses, at > least one connection attemt typ0 > Fix this behaviour by cleaning stale addinfo objects. Stared at code and it looks fine - same cleanup logic as in do_close_link_socket(). Built and tested with MSVC - reproduced assert withou

Re: [Openvpn-devel] [PATCH] Support for wolfSSL in OpenVPN

2020-09-16 Thread David Sommerseth
On 17/09/2020 00:05, Arne Schwabe wrote: > This snippet in the configure.ac looks strange: > > if test -n "${WOLFSSL_DIR}"; then > wolfssldir="${WOLFSSL_DIR}" > else > wolfssldir="/usr/local/include/wolfssl" > fi > > I am not sure hardcoding a /usr/lo

Re: [Openvpn-devel] [PATCH] Support for wolfSSL in OpenVPN

2020-09-16 Thread Arne Schwabe
Am 16.09.20 um 11:45 schrieb Juliusz Sosinowicz: > Hi Arne, > > a quick update. A PR is now open in wolfSSL with fixes for OpenVPN master. This is the version that I could actually take a deeper look at, so here are my results. It generally works but there seems some loose ends: I am still seei

Re: [Openvpn-devel] [PATCH] Added client-ip to NAT config

2020-09-16 Thread Rafael Gava
Ops, sorry. It's the same. I thought it was not sent to the group. :-) BR Gava On Wed, Sep 16, 2020 at 5:35 PM Gert Doering wrote: > Hi, > > On Wed, Sep 16, 2020 at 04:56:17PM +, Rafael Gava de Oliveira via > Openvpn-devel wrote: > > A couple years ago I submitted this patch which allows t

Re: [Openvpn-devel] [PATCH] Added client-ip to NAT config

2020-09-16 Thread Gert Doering
Hi, On Wed, Sep 16, 2020 at 04:56:17PM +, Rafael Gava de Oliveira via Openvpn-devel wrote: > A couple years ago I submitted this patch which allows the user to set the > 'client-ip' as a convenient way to use the leased IP address received from > OpenVPN server in NAT configuration. For exa

[Openvpn-devel] [PATCH applied] Re: build: Fix make distclean/distcheck

2020-09-16 Thread Gert Doering
Acked-by: Gert Doering I haven't tested this (my "distcheck capable" machine is still down), but it looks reasonable. Your patch has been applied to the master and release/2.5 branch. commit 6345cea86bde14b22a8024cad5026a7d302db25c (master) commit 55f4fe3a0d04b35f0e817c5a34246d9bda40e936 (relea

[Openvpn-devel] [PATCH] build: Fix make distclean/distcheck

2020-09-16 Thread David Sommerseth
In commit 0b5141d8f94 the sample-plugins got partially migrated to automake. But since it was not fully integrated within the full standard build, the sample/sample-plugins/Makefile was not removed by 'make distclean', which annoys 'make distcheck'. The simplest way is just to explicitly enlist t

Re: [Openvpn-devel] LD Errors / vpn_connect or vpn_init

2020-09-16 Thread David Sommerseth
On 16/09/2020 18:49, John A wrote: > Hey y’all, > > I am new to this list and have been on listservs/majordomos since themid-90s. > I visit here today to ask and hopefullyreceivean answer. > > I haveerrors of undefinedreferences such as: > > /tmp/ccDkPqm5.ltrans7.ltrans.o: In function `vpn_init(

[Openvpn-devel] [PATCH] Added client-ip to NAT config

2020-09-16 Thread Rafael Gava de Oliveira via Openvpn-devel
Hello guys, A couple years ago I submitted this patch which allows the user to set the 'client-ip' as a convenient way to use the leased IP address received from OpenVPN server in NAT configuration. For example: client-nat snat client-ip 255.255.255.255 172.20.1.15 , where 'client-ip' string i

[Openvpn-devel] LD Errors / vpn_connect or vpn_init

2020-09-16 Thread John A
Hey y'all, I am new to this list and have been on listservs/majordomos since the mid-90s. I visit here today to ask and hopefully receive an answer. I have errors of undefined references such as: /tmp/ccDkPqm5.ltrans7.ltrans.o: In function `vpn_init()': :(.text+0x1051): undefined reference to `o

[Openvpn-devel] [PATCH applied] Re: sample-plugins: Partially autotoolize the sample-plugins build

2020-09-16 Thread Gert Doering
Acked-by: Gert Doering Works for in-tree and out-of-tree builds now, both "just gmake" and "gmake simple/simple.so". The gmake requirement is well documented and "good enough" for this dusty corner where people very rarely need to build stuff. (It might be solvable by replacing the (foreach) st

Re: [Openvpn-devel] [PATCH v3] sample-plugins: Partially autotoolize the sample-plugins build

2020-09-16 Thread David Sommerseth
[resent from proper address] On 16/09/2020 15:48, Gert Doering wrote: > Hi, > > On Tue, Sep 15, 2020 at 10:52:54PM +0200, David Sommerseth wrote: >> --- >> v2 - Process README files with correct instructions and details >> v3 - Add missing -I$(top_srcdir)/include and explicitly state GNU Make >>

[Openvpn-devel] [PATCH v4] sample-plugins: Partially autotoolize the sample-plugins build

2020-09-16 Thread David Sommerseth
The sample-plugins have their own set of build/winbuild scripts in each of these plugin directories. This does not give a good way to reuse various macros the autoconf/automake/configure process enables; which can contain important macros to make some code build without errors or warnings. Normal

[Openvpn-devel] [PATCH v2] Fix fatal error at switching remotes (#629)

2020-09-16 Thread Vladislav Grishenko
If remote server has been resolved to multiple addresses, at least one connection attemt has been made and connection to the last address was skipped by management - resolved earlier link socket addrinfo objects will not be cleared neither on instance close nor in the next connection entry loop. Th

Re: [Openvpn-devel] [PATCH v3] sample-plugins: Partially autotoolize the sample-plugins build

2020-09-16 Thread Gert Doering
Hi, On Tue, Sep 15, 2020 at 10:52:54PM +0200, David Sommerseth wrote: > --- > v2 - Process README files with correct instructions and details > v3 - Add missing -I$(top_srcdir)/include and explicitly state GNU Make > requirement Unfortunately, we need a v4... stupid me... For in-tree builds

[Openvpn-devel] [PATCH] Fix fatal error at switching remotes (#629)

2020-09-16 Thread Vladislav Grishenko
If remote server has been resolved to multiple addresses, at least one connection attemt has been made and connection to the last address was skipped by management - resolved earlier link socket addrinfo objects will not be cleared neither on instance close nor in the next connection entry loop. Th

[Openvpn-devel] Summary of the community meeting (16th September 2020)

2020-09-16 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wed 16th September 2020 Time: 11:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local

Re: [Openvpn-devel] [PATCH] Support for wolfSSL in OpenVPN

2020-09-16 Thread Juliusz Sosinowicz
Hi Arne, a quick update. A PR is now open in wolfSSL with fixes for OpenVPN master. Sincerely Juliusz On 10/09/2020 14:16, Arne Schwabe wrote: Am 10.09.20 um 14:11 schrieb Juliusz Sosinowicz: Hi Arne, I understand your concern and apologize for the delay. We have been busy with the release o