Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-29 Thread Gert Doering
Hi, On Tue, Aug 29, 2017 at 06:19:21PM +0200, Jan Just Keijser wrote: > my biggest complaint about the so-called modern $() notation is that it > clashes/confuses the heck out of me when using proper variable usage, > e.g. I find >output=`${SOME_COMMAND} ${SOME_ARGS}` > much better readable

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-29 Thread Jan Just Keijser
Hi, On 25/08/17 03:41, Antonio Quartulli wrote: On 25/08/17 04:21, David Sommerseth wrote: On 24/08/17 21:18, Gert Doering wrote: (gen-release-tarballs.sh only needs to work on FreeBSD and Linux, and FreeBSD's /bin/sh is sufficiently modern so so it's likely to work - but the test scripts n

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
On 25/08/17 04:21, David Sommerseth wrote: > On 24/08/17 21:18, Gert Doering wrote: >> (gen-release-tarballs.sh only needs to work on FreeBSD and Linux, and >> FreeBSD's /bin/sh is sufficiently modern so so it's likely to work >> - but the test scripts need to run robustly everywhere a user buil

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread David Sommerseth
On 24/08/17 21:18, Gert Doering wrote: > (gen-release-tarballs.sh only needs to work on FreeBSD and Linux, and > FreeBSD's /bin/sh is sufficiently modern so so it's likely to work > - but the test scripts need to run robustly everywhere a user builds, > so never assume "because bash says so!" is a

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Gert Doering
Hi, On Thu, Aug 24, 2017 at 09:33:05PM +0800, Antonio Quartulli wrote: > The backquotes for command substitution in bash are > considered old-style in favour of the more modern $() [1]. > Substitute them. > > [1]https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html#Command-

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
On 25/08/17 02:06, David Sommerseth wrote: > On 24/08/17 16:42, Antonio Quartulli wrote: >> dev-tools/gen-release-tarballs.sh is only for devs, while >> tests/t_cltsrv.sh is for running some tests, but I am not sure sure how >> the latter would interact with non-linux systems. >> >> Maybe Gert kn

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread David Sommerseth
On 24/08/17 16:42, Antonio Quartulli wrote: > dev-tools/gen-release-tarballs.sh is only for devs, while > tests/t_cltsrv.sh is for running some tests, but I am not sure sure how > the latter would interact with non-linux systems. > > Maybe Gert knows(?) Tried running them through ksh or dash? Th

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
dev-tools/gen-release-tarballs.sh is only for devs, while tests/t_cltsrv.sh is for running some tests, but I am not sure sure how the latter would interact with non-linux systems. Maybe Gert knows(?) Cheers, On 24/08/17 22:37, Илья Шипицин wrote: > openvpn is also built on many non bash systems.

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Илья Шипицин
openvpn is also built on many non bash systems. what about them? 24 авг. 2017 г. 18:34 пользователь "Antonio Quartulli" написал: The backquotes for command substitution in bash are considered old-style in favour of the more modern $() [1]. Substitute them. [1]https://www.gnu.org/software/bash/m

[Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
The backquotes for command substitution in bash are considered old-style in favour of the more modern $() [1]. Substitute them. [1]https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html#Command-Substitution Signed-off-by: Antonio Quartulli --- note: I did not really know h