Hi,
On 08-11-16 09:44, Steffan Karger wrote:
> I didn't look at the code itself (David already did), but two very minor
> nitpicks I ran into while rebasing my src/openvpn/* unit tests on this
> patch:
>
> [..]
Apart from this, I noticed that builds that depend on
OPENSSL_CFLAGS/MBEDTLS_CFLAGS (
Hi,
I didn't look at the code itself (David already did), but two very minor
nitpicks I ran into while rebasing my src/openvpn/* unit tests on this
patch:
On 28-10-16 18:42, Heiko Hund wrote:
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1273,6 +1273,7 @@ AC_CONFIG_FILES([
> tests/unit
Hi,
On 08-11-16 00:28, David Sommerseth wrote:
> I will wait with applying this patch to the git tree until all the other
> patches in this series have been reviewed and ACKed.
Actually, this patch does not need the follow-up patches, right? In
that case, I would strongly prefer if we didn't wai
On 28/10/16 18:42, Heiko Hund wrote:
> misc.c is too crowded with different things to perform any
> sane unit testing due to its dependencies. So, in order to re-write
> the #ifdef'ed tests for the argv_* family of functions into unit
> tests I moved them into a dedicated file.
>
> Signed-off-by:
misc.c is too crowded with different things to perform any
sane unit testing due to its dependencies. So, in order to re-write
the #ifdef'ed tests for the argv_* family of functions into unit
tests I moved them into a dedicated file.
Signed-off-by: Heiko Hund
---
configure.ac
