Re: [Openvpn-devel] [PATCH 2/3] Refactor counting number of element in a : delimited list into function

2020-04-16 Thread Arne Schwabe
>> > > Other than my little nitpicks above, the patch looks good. > However, I have a question. > > Since you are refactoring this code and this is going to master/2.5, why > not reimplementing the get_num_elements() function using strtok() ? > strsep/strok have the disadvantage of modifying

Re: [Openvpn-devel] [PATCH 2/3] Refactor counting number of element in a : delimited list into function

2020-04-15 Thread Antonio Quartulli
Hi, On 01/04/2020 12:21, Arne Schwabe wrote: > --- > src/openvpn/misc.c| 18 ++ > src/openvpn/misc.h| 13 + > src/openvpn/ssl_mbedtls.c | 15 ++- > 3 files changed, 33 insertions(+), 13 deletions(-) > > diff --git a/src/openvpn/misc.c