Re: [Openvpn-devel] [PATCH v2] Add TFTP and WPAD DHCP options

Jan Just Keijser wrote: Jan Just Keijser wrote: Gert Doering wrote: On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote: +write_dhcp_str (buf, 66, o->tftp, ); +write_dhcp_str (buf, 150, o->tftp, ); This does not look safe to me (or I'm overlooking something) - if

Re: [Openvpn-devel] [PATCH v2] Add TFTP and WPAD DHCP options

Hi, Jan Just Keijser wrote: Gert Doering wrote: On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote: +write_dhcp_str (buf, 66, o->tftp, ); +write_dhcp_str (buf, 150, o->tftp, ); This does not look safe to me (or I'm overlooking something) - if o->tftp is not

Re: [Openvpn-devel] [PATCH v2] Add TFTP and WPAD DHCP options

Hi, Gert Doering wrote: Hi, On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote: +write_dhcp_str (buf, 66, o->tftp, ); +write_dhcp_str (buf, 150, o->tftp, ); This does not look safe to me (or I'm overlooking something) - if o->tftp is not set, it will do