Re: [Openvpn-devel] [PATCH v5 03/14] client-connect: Refactor multi_client_connect_source_ccd

2020-07-14 Thread Antonio Quartulli
Hi, On 11/07/2020 11:36, Arne Schwabe wrote: > From: Fabian Knittel > > Refactor multi_client_connect_source_ccd(), so that options_server_import() > (or > the success path in general) is only entered in one place within the function. > > Signed-off-by: Fabian Knittel > > Patch V5: Simplify

Re: [Openvpn-devel] [PATCH v5 03/14] client-connect: Refactor multi_client_connect_source_ccd

2020-07-13 Thread tincanteksup
1x grammar On 11/07/2020 10:36, Arne Schwabe wrote: From: Fabian Knittel Refactor multi_client_connect_source_ccd(), so that options_server_import() (or the success path in general) is only entered in one place within the function. Signed-off-by: Fabian Knittel Patch V5: Simplify the logic

Re: [Openvpn-devel] [PATCH v5 03/14] client-connect: Refactor multi_client_connect_source_ccd

2020-07-13 Thread Antonio Quartulli
Hi, On 13/07/2020 13:29, Gert Doering wrote: > instead, maybe this? > >> +const char *ccd_client = >> + platform_gen_path(mi->context.options.client_config_dir, >> + tls_common_name(mi->context.c2.tls_multi, >> +

Re: [Openvpn-devel] [PATCH v5 03/14] client-connect: Refactor multi_client_connect_source_ccd

2020-07-13 Thread Gert Doering
Hi, On Sat, Jul 11, 2020 at 11:36:44AM +0200, Arne Schwabe wrote: > From: Fabian Knittel > > Refactor multi_client_connect_source_ccd(), so that options_server_import() > (or > the success path in general) is only entered in one place within the function. > > Signed-off-by: Fabian Knittel Al

[Openvpn-devel] [PATCH v5 03/14] client-connect: Refactor multi_client_connect_source_ccd

2020-07-11 Thread Arne Schwabe
From: Fabian Knittel Refactor multi_client_connect_source_ccd(), so that options_server_import() (or the success path in general) is only entered in one place within the function. Signed-off-by: Fabian Knittel Patch V5: Simplify the logic even further to make more easy to understand. Signed-o